Clean up and simplify some things #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is left over from v2 and not used in v3. Currently, we map model strings to model definitions directly in the Wake class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
The biggest change here is that I've removed the wake model
model_stringattribute. This was left over from v2, and in v3 we map model strings directly to their model definitions in the Wake class. While FLORIS doesn't use this attribute internally, @paulf81 @pjstanle is this something you or others use in your scripts?Otherwise, this pull request removes the outdated Curl model class and other code and import-statements that aren't used.
Related issue, if one exists
None, just spring cleaning.
Impacted areas of the software
Wake model definitions, most files in
floris.simulation, andfloris_interfaceimports