New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes to code and documentation #613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bayc the specific change I'm hoping to get your eyes on are:
|
This is ultimately used to construct the `power_interp` array, so it is redundant here.
@rafmudaf Thanks for calling these out specifically! Responses are in italics below.
|
bayc
approved these changes
Apr 25, 2023
Thanks for the review @bayc. Is it worth retaining the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of random changes and improvements
This pull request includes a variety of changes and improvements that don't easily fall under other ongoing work. The changes are listed below.
These changes only impact the quality of the code itself. There are no API or functionality changes.
Related issue
No issue, but there are some comments:
Impacted areas of the software
The code within
FlorisInterface
, the solvers,Farm
,FlowField
, andutilities.wind_delta
are modified, but the functionality and results in all of these modules should not change.Test results, if applicable
Here's a listing of where the changes are tested.
utilities_unit_test
already has a test for thisturbine_unit_test
Time series switch
These plots are the results from the time series example (21). The first is before the change to the time series flag and the second is after the change. They are different because that example creates a random-walk for the wind directions. However, this show that the time series flag is enabled correctly, and this verifies the change.
Redundant array slices
This is verified with the same example as above, 21. The plot below shows that the code runs, as expected, so removing the extra slices did not impact the shape of the arrays.