Baseline fixes 2 #106
Merged
Baseline fixes 2 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Stratified) correctly by checking it it's a storage tank only, and whether it's connected on the source side to a plant loop (related #96)
…s. Also added a custom = '90.1-2007 with addenda dn' which will let you use heated only (sys 9 and 10 in 90.1-2010, 10 and 11 in addenda dn) with 90.1-2007
…xed (OS doesn't have the WAterHeater:Sizing objects...)
Conflicts: openstudio-standards/lib/openstudio-standards/standards/Standards.Model.rb openstudio-standards/lib/openstudio-standards/standards/Standards.ThermalZone.rb
…o baseline_fixes_2 Conflicts: openstudio-standards/lib/openstudio-standards/standards/Standards.CoilCoolingDXSingleSpeed.rb openstudio-standards/lib/openstudio-standards/standards/Standards.Model.rb openstudio-standards/lib/openstudio-standards/standards/Standards.PlantLoop.rb openstudio-standards/lib/openstudio-standards/standards/Standards.WaterHeaterMixed.rb
…o baseline_fixes_2 Conflicts: openstudio-standards/lib/openstudio-standards/standards/Standards.CoilCoolingDXSingleSpeed.rb openstudio-standards/lib/openstudio-standards/standards/Standards.Model.rb openstudio-standards/lib/openstudio-standards/standards/Standards.PlantLoop.rb openstudio-standards/lib/openstudio-standards/standards/Standards.WaterHeaterMixed.rb
…up HVAC to them later
…heet for all lookups
…ontrol is required or not
…ly updated for 90.1-2013
… DX coils and chillers.
…ere the zones have multipliers.
…or pri/sec CHW systems and CW systems.
… reflect 90.1-2013
…ing to the E+ IDD, these limits are applied even when the control type would not indicate that they would be used.
This was referenced Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of changes to fix issues identified during the testing of the baseline automation feature.