Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdjustmentFactors variable names do not match SAM #164

Closed
dguittet opened this issue Mar 21, 2024 · 2 comments · Fixed by NREL/SAM#1826
Closed

AdjustmentFactors variable names do not match SAM #164

dguittet opened this issue Mar 21, 2024 · 2 comments · Fixed by NREL/SAM#1826

Comments

@dguittet
Copy link
Collaborator

dguittet commented Mar 21, 2024

The Adjustment Factor variables in the SAM GUI have the prefix adjust_ whereas the PySAM versions do not, as shown for Pvwattsv8 here: https://nrel-pysam.readthedocs.io/en/main/modules/Pvwattsv8.html#adjustmentfactors-group

This discrepancy will lead to issues reading inputs that were exported from the SAM GUI.

The workaround now is to modify the variable name:

for k, v in pv_inputs.items():
    if 'adjust_' in k:
         k = k.replace('adjust_', '')
@dguittet
Copy link
Collaborator Author

Fix in 9ded981

@dguittet
Copy link
Collaborator Author

dguittet commented Jun 5, 2024

Previous fix of k = k.split('adjust_')[1] does not work when there are multiple types of adjustment factors (such as sf and dc)

The correct fix is

k = k.replace('adjust_', '')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant