Feat/offshore lcp #188
Merged
Feat/offshore lcp #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: reVX/least_cost_xmission/aoswt_utilities.py
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 81.36% 81.09% -0.28%
==========================================
Files 113 113
Lines 13369 13443 +74
==========================================
+ Hits 10878 10901 +23
- Misses 2491 2542 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* Allowed regions file to be passed through in add_reeds_cols, ignored CRS warning in outlier finding step. * Changed argument to in geopandas sjoin call * Docstring updates * Fix tests * Add guard to protect from third-party packages forcing a `logging.basicConfig` call * Add missing parentheses * Make slope friction parameters user changable * Transformed constants to uppercase * Converted print statements to logger calls * Fix deprecated pd.DataFrame.append() * Fix minor syntax issues * Fix line length * Change default out dir * Fix spelling error * Friction config and minor cli changes * Update reV version req * Update to conform to new reV API * Bump version * Minor PR changes * Improve split to geojson logging * Update workflow to use trusted publishing * Allow minimum off-shore friction * Fix line length linter issue --------- Co-authored-by: WilliamsTravis <travis.williams@nrel.gov> Co-authored-by: ppinchuk <ppinchuk@nrel.gov>
ppinchuk
previously approved these changes
Aug 16, 2023
* update doc for aoswt layer creation * Minor doc changes
ppinchuk
approved these changes
Aug 17, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Include bathymetry in AOSWT friction * Ignore function complexity warning * Add sc_point_gids back to config after removal during merge * Allow buffer on land mask creation * Added back `sc_point_gids` CLI option * Updated docstrings * Add missing quote * Fixed local unbound variable error * Fixed radius not increasing with area bug * Minor doc updates * Fixed counting scheme for logger messages * Minor doc updates * Added `expand_radius` option to CLI * Updated docstring * Clipping radius increased linearly instead of exponentially * FIx bug where sc_features can be empty before recomputing radius * Return empty dataframe if no paths found * Make slope friction parameters user changable (#191) * Allowed regions file to be passed through in add_reeds_cols, ignored CRS warning in outlier finding step. * Changed argument to in geopandas sjoin call * Docstring updates * Fix tests * Add guard to protect from third-party packages forcing a `logging.basicConfig` call * Add missing parentheses * Make slope friction parameters user changable * Transformed constants to uppercase * Converted print statements to logger calls * Fix deprecated pd.DataFrame.append() * Fix minor syntax issues * Fix line length * Change default out dir * Fix spelling error * Friction config and minor cli changes * Update reV version req * Update to conform to new reV API * Bump version * Minor PR changes * Improve split to geojson logging * Update workflow to use trusted publishing * Allow minimum off-shore friction * Fix line length linter issue --------- Co-authored-by: WilliamsTravis <travis.williams@nrel.gov> Co-authored-by: ppinchuk <ppinchuk@nrel.gov> * Minor log update * Fix linter issues * Allow out dir to not exist in CLI * Start updating doc for AOSWT * Doc/document new aoswt options (#193) * update doc for aoswt layer creation * Minor doc changes --------- Co-authored-by: ppinchuk <ppinchuk@nrel.gov> Co-authored-by: WilliamsTravis <travis.williams@nrel.gov>
pesap
pushed a commit
to kodiobika/reVX
that referenced
this pull request
Sep 6, 2023
* Include bathymetry in AOSWT friction * Ignore function complexity warning * Add sc_point_gids back to config after removal during merge * Allow buffer on land mask creation * Added back `sc_point_gids` CLI option * Updated docstrings * Add missing quote * Fixed local unbound variable error * Fixed radius not increasing with area bug * Minor doc updates * Fixed counting scheme for logger messages * Minor doc updates * Added `expand_radius` option to CLI * Updated docstring * Clipping radius increased linearly instead of exponentially * FIx bug where sc_features can be empty before recomputing radius * Return empty dataframe if no paths found * Make slope friction parameters user changable (NREL#191) * Allowed regions file to be passed through in add_reeds_cols, ignored CRS warning in outlier finding step. * Changed argument to in geopandas sjoin call * Docstring updates * Fix tests * Add guard to protect from third-party packages forcing a `logging.basicConfig` call * Add missing parentheses * Make slope friction parameters user changable * Transformed constants to uppercase * Converted print statements to logger calls * Fix deprecated pd.DataFrame.append() * Fix minor syntax issues * Fix line length * Change default out dir * Fix spelling error * Friction config and minor cli changes * Update reV version req * Update to conform to new reV API * Bump version * Minor PR changes * Improve split to geojson logging * Update workflow to use trusted publishing * Allow minimum off-shore friction * Fix line length linter issue --------- Co-authored-by: WilliamsTravis <travis.williams@nrel.gov> Co-authored-by: ppinchuk <ppinchuk@nrel.gov> * Minor log update * Fix linter issues * Allow out dir to not exist in CLI * Start updating doc for AOSWT * Doc/document new aoswt options (NREL#193) * update doc for aoswt layer creation * Minor doc changes --------- Co-authored-by: ppinchuk <ppinchuk@nrel.gov> Co-authored-by: WilliamsTravis <travis.williams@nrel.gov>
pesap
pushed a commit
to kodiobika/reVX
that referenced
this pull request
Sep 20, 2023
* Include bathymetry in AOSWT friction * Ignore function complexity warning * Add sc_point_gids back to config after removal during merge * Allow buffer on land mask creation * Added back `sc_point_gids` CLI option * Updated docstrings * Add missing quote * Fixed local unbound variable error * Fixed radius not increasing with area bug * Minor doc updates * Fixed counting scheme for logger messages * Minor doc updates * Added `expand_radius` option to CLI * Updated docstring * Clipping radius increased linearly instead of exponentially * FIx bug where sc_features can be empty before recomputing radius * Return empty dataframe if no paths found * Make slope friction parameters user changable (NREL#191) * Allowed regions file to be passed through in add_reeds_cols, ignored CRS warning in outlier finding step. * Changed argument to in geopandas sjoin call * Docstring updates * Fix tests * Add guard to protect from third-party packages forcing a `logging.basicConfig` call * Add missing parentheses * Make slope friction parameters user changable * Transformed constants to uppercase * Converted print statements to logger calls * Fix deprecated pd.DataFrame.append() * Fix minor syntax issues * Fix line length * Change default out dir * Fix spelling error * Friction config and minor cli changes * Update reV version req * Update to conform to new reV API * Bump version * Minor PR changes * Improve split to geojson logging * Update workflow to use trusted publishing * Allow minimum off-shore friction * Fix line length linter issue --------- Co-authored-by: WilliamsTravis <travis.williams@nrel.gov> Co-authored-by: ppinchuk <ppinchuk@nrel.gov> * Minor log update * Fix linter issues * Allow out dir to not exist in CLI * Start updating doc for AOSWT * Doc/document new aoswt options (NREL#193) * update doc for aoswt layer creation * Minor doc changes --------- Co-authored-by: ppinchuk <ppinchuk@nrel.gov> Co-authored-by: WilliamsTravis <travis.williams@nrel.gov>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most recent changes to offshore wind transmission paths code