Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Layer Creator Functionality #213

Merged
merged 16 commits into from
May 13, 2024
Merged

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented May 10, 2024

@mikebannis feel free to take a peek and let me know if you see any red flags (but no pressure)

This PR gets about 90% of the way toward generalizing the Layer Creator class. What is left to do is move it to a more general location and build a small CLI for it, but that can happen once we get a project that needs this kind of functionality

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2024

Codecov Report

Attention: Patch coverage is 87.92453% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 82.68%. Comparing base (dc2d62b) to head (3cc31f6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   79.10%   82.68%   +3.58%     
==========================================
  Files         125      123       -2     
  Lines       14082    14064      -18     
==========================================
+ Hits        11139    11629     +490     
+ Misses       2943     2435     -508     
Flag Coverage Δ
unittests 82.68% <87.92%> (+3.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
reVX/config/least_cost_xmission.py 90.79% <100.00%> (-0.28%) ⬇️
reVX/config/transmission_layer_creation.py 100.00% <100.00%> (ø)
reVX/least_cost_xmission/__init__.py 100.00% <ø> (ø)
reVX/least_cost_xmission/config/__init__.py 100.00% <100.00%> (ø)
reVX/least_cost_xmission/config/constants.py 100.00% <100.00%> (ø)
reVX/least_cost_xmission/layers/__init__.py 100.00% <100.00%> (ø)
reVX/least_cost_xmission/layers/base.py 94.44% <100.00%> (ø)
...eVX/least_cost_xmission/layers/dry_cost_creator.py 96.18% <100.00%> (ø)
reVX/least_cost_xmission/least_cost_paths.py 97.45% <100.00%> (ø)
reVX/least_cost_xmission/least_cost_paths_cli.py 70.40% <100.00%> (ø)
... and 10 more

... and 6 files with indirect coverage changes

@ppinchuk ppinchuk marked this pull request as ready for review May 12, 2024 05:07
@ppinchuk ppinchuk requested a review from mikebannis May 13, 2024 15:32
@ppinchuk ppinchuk changed the title [WIP] Generalize layer creator Generalize Layer Creator Functionality May 13, 2024
@mikebannis
Copy link
Collaborator

Generally looks good, left a couple minor comments.

mikebannis
mikebannis previously approved these changes May 13, 2024
@ppinchuk
Copy link
Collaborator Author

Thanks for the review @mikebannis - these were exactly the kinds of things I wanted to catch :)

@ppinchuk ppinchuk merged commit 1cadcc5 into main May 13, 2024
8 checks passed
@ppinchuk ppinchuk deleted the pp/generalize_layer_creator branch May 13, 2024 22:12
github-actions bot pushed a commit that referenced this pull request May 13, 2024
Generalize Layer Creator Functionality
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants