-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Layer Creator Functionality #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 79.10% 82.68% +3.58%
==========================================
Files 125 123 -2
Lines 14082 14064 -18
==========================================
+ Hits 11139 11629 +490
+ Misses 2943 2435 -508
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ppinchuk
changed the title
[WIP] Generalize layer creator
Generalize Layer Creator Functionality
May 13, 2024
mikebannis
reviewed
May 13, 2024
mikebannis
reviewed
May 13, 2024
mikebannis
reviewed
May 13, 2024
mikebannis
reviewed
May 13, 2024
Generally looks good, left a couple minor comments. |
mikebannis
previously approved these changes
May 13, 2024
Thanks for the review @mikebannis - these were exactly the kinds of things I wanted to catch :) |
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
Generalize Layer Creator Functionality
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikebannis feel free to take a peek and let me know if you see any red flags (but no pressure)
This PR gets about 90% of the way toward generalizing the Layer Creator class. What is left to do is move it to a more general location and build a small CLI for it, but that can happen once we get a project that needs this kind of functionality