Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear length mult implementation #214

Merged
merged 3 commits into from
May 14, 2024
Merged

Linear length mult implementation #214

merged 3 commits into from
May 14, 2024

Conversation

ppinchuk
Copy link
Collaborator

Go from stepwise function to linear interpolation for length multiplier calculation.

Old is orange, new is blue:

image

@ppinchuk ppinchuk marked this pull request as ready for review May 13, 2024 22:16
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.78%. Comparing base (1cadcc5) to head (0db14c2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   79.14%   82.78%   +3.64%     
==========================================
  Files         123      123              
  Lines       14064    14160      +96     
==========================================
+ Hits        11131    11723     +592     
+ Misses       2933     2437     -496     
Flag Coverage Δ
unittests 82.78% <98.03%> (+3.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
reVX/config/least_cost_xmission.py 90.96% <100.00%> (+0.16%) ⬆️
reVX/least_cost_xmission/least_cost_xmission.py 90.00% <ø> (ø)
...eVX/least_cost_xmission/least_cost_xmission_cli.py 49.13% <100.00%> (+0.22%) ⬆️
tests/test_xmission_least_cost.py 95.32% <100.00%> (+0.06%) ⬆️
reVX/least_cost_xmission/trans_cap_costs.py 85.31% <95.45%> (+0.27%) ⬆️

... and 16 files with indirect coverage changes

@ppinchuk ppinchuk merged commit b793128 into main May 14, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request May 14, 2024
Linear length mult implementation
@ppinchuk ppinchuk deleted the pp/linear_length_mult branch July 2, 2024 15:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants