Gb/plexos gid utils #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRossol
requested changes
Apr 8, 2020
There was a problem hiding this comment.
Primary requests:
- Avoid ambiguous args and out vars like i
- For consistency use existing approach to parallelization, i.e. max_workers kwarg, sub-methods for parallel_run vs serial_run
- Ensure line spacing after with's, for's, and if's and before returns to help with readability
|
FYI I made a bugfix on master, you shouldn't need to rebase unless you want to |
grantbuster
force-pushed
the
gb/plexos_gid_utils
branch
from
7e89174
to
28a4d9f
Compare
MRossol
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added plexos utility for a common GID extraction task I perform for the 5min data runs (naris, exevents).