-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Setpoint and Setpoint Schedule Distributions #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ejhw, @aspeake: Are we introducing these changes into the resstock-estimation repo?
Eventually we want to incorporate the script into the tsv maker, but I am currently using an existing script I had on this branch to get the tsvs updated and merged ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aspeake Thanks for the clarification. Can you add a source tag to the bottom of the TSVs? Something like:
# Source: Constructed using U.S. EIA 2009 Residential Energy Consumption Survey (RECS) microdata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be relatively easy to add a sample_count (and sample_weight) column, so we know how many samples are supporting each distribution?
It looks like each Option bin is within "+2" not within "+/- 1". i.e., Shouldn't Option=62F represent 61-63F instead of 62-64F? |
Our initial approach binned the setpoints into 2 degree bins, then took the nearest integer to the median value in each bin. So the bin [62 - 64) , had a median value closest to 62. |
Gotcha, thanks for explaining. |
addressed in 312d0f4 |
Thanks. Some of these sample counts are lower than I'd like (e.g., in 3C). Can you pool samples from 3B and 3C to get a distribution for both? I think that fixes the worst case for me. |
We all decided to not do any lumping at this point. Hopefully these distributions will be replaced by a dataset with more samples (ecobee) in the future. |
…48ce2 fa5a0548ce2 BuildResidentialHPXML measure: Shared water heater (#467) 172d03c6995 Add valid_attr method in. 3b91ea5d508 Set shared pv system to false. ceed3a61bbe Merge branch 'master' into build-res-hpxml-v3 12da8ffe388 Merge pull request #465 from NREL/shared_pv 847006d6f6d Merge pull request #468 from NREL/shared_parking_garages 3312c7c2406 Document "garage" should only be used for single-family garages, not parking garages. 355f856d31a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into shared_pv c3574d4a681 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into shared_pv 2efe2d0109c First pass. git-subtree-dir: resources/hpxml-measures git-subtree-split: fa5a0548ce2df7f21d6caa6b792055a8d21fcb6c
Pull Request Description
Updates the thermostat heating and cooling setpoint distributions (setpoint, has offset, offset magnitude, offset schedule) to be dependent on IECC climate zone instead of AIA zone.
The code used to generate these files is found here: https://github.com/NREL/resstock-estimation/blob/tsp_updates/sources/recs/2009/Setback%20Distributions.ipynb
Checklist
Not all may apply:
project_testing
project_testing
runs without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.