Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Setpoint and Setpoint Schedule Distributions #468

Merged
merged 9 commits into from
Aug 10, 2020

Conversation

aspeake
Copy link
Contributor

@aspeake aspeake commented Jul 22, 2020

Pull Request Description

Updates the thermostat heating and cooling setpoint distributions (setpoint, has offset, offset magnitude, offset schedule) to be dependent on IECC climate zone instead of AIA zone.

The code used to generate these files is found here: https://github.com/NREL/resstock-estimation/blob/tsp_updates/sources/recs/2009/Setback%20Distributions.ipynb

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing (green) on circleci
  • The changelog has been updated appropriately
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@aspeake aspeake requested review from ejhw and afontani July 22, 2020 15:09
Copy link
Contributor

@afontani afontani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejhw, @aspeake: Are we introducing these changes into the resstock-estimation repo?

@aspeake
Copy link
Contributor Author

aspeake commented Jul 22, 2020

@ejhw, @aspeake: Are we introducing these changes into the resstock-estimation repo?

Eventually we want to incorporate the script into the tsv maker, but I am currently using an existing script I had on this branch to get the tsvs updated and merged ASAP.

@afontani afontani changed the title Update tsp distributions Update Setpoint and Setpoint Schedule Distributions Jul 22, 2020
Copy link
Contributor

@afontani afontani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aspeake Thanks for the clarification. Can you add a source tag to the bottom of the TSVs? Something like:

# Source: Constructed using U.S. EIA 2009 Residential Energy Consumption Survey (RECS) microdata.

@aspeake
Copy link
Contributor Author

aspeake commented Jul 22, 2020

@aspeake Thanks for the clarification. Can you add a source tag to the bottom of the TSVs? Something like:

# Source: Constructed using U.S. EIA 2009 Residential Energy Consumption Survey (RECS) microdata.

@afontani Addressed in ec3cf6a

@aspeake
Copy link
Contributor Author

aspeake commented Jul 28, 2020

@afontani @ejhw RECS building type dependency has been added and setback period options were expanded (+/- 5 hour shifts), and the PR should be ready for another review.

Copy link
Contributor

@ejhw ejhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be relatively easy to add a sample_count (and sample_weight) column, so we know how many samples are supporting each distribution?

@ejhw
Copy link
Contributor

ejhw commented Jul 29, 2020

It looks like each Option bin is within "+2" not within "+/- 1". i.e., Shouldn't Option=62F represent 61-63F instead of 62-64F?

@aspeake
Copy link
Contributor Author

aspeake commented Jul 29, 2020

It looks like each Option bin is within "+2" not within "+/- 1". i.e., Shouldn't Option=62F represent 61-63F instead of 62-64F?

Our initial approach binned the setpoints into 2 degree bins, then took the nearest integer to the median value in each bin. So the bin [62 - 64) , had a median value closest to 62.

@ejhw
Copy link
Contributor

ejhw commented Jul 29, 2020

Our initial approach binned the setpoints into 2 degree bins, then took the nearest integer to the median value in each bin. So the bin [62 - 64) , had a median value closest to 62.

Gotcha, thanks for explaining.

@aspeake
Copy link
Contributor Author

aspeake commented Jul 29, 2020

Would it be relatively easy to add a sample_count (and sample_weight) column, so we know how many samples are supporting each distribution?

addressed in 312d0f4

@ejhw
Copy link
Contributor

ejhw commented Jul 29, 2020

Would it be relatively easy to add a sample_count (and sample_weight) column, so we know how many samples are supporting each distribution?

addressed in 312d0f4

Thanks. Some of these sample counts are lower than I'd like (e.g., in 3C). Can you pool samples from 3B and 3C to get a distribution for both? I think that fixes the worst case for me.

@aspeake aspeake requested a review from afontani July 31, 2020 20:03
@ejhw
Copy link
Contributor

ejhw commented Aug 3, 2020

Would it be relatively easy to add a sample_count (and sample_weight) column, so we know how many samples are supporting each distribution?

addressed in 312d0f4

Thanks. Some of these sample counts are lower than I'd like (e.g., in 3C). Can you pool samples from 3B and 3C to get a distribution for both? I think that fixes the worst case for me.

We all decided to not do any lumping at this point. Hopefully these distributions will be replaced by a dataset with more samples (ecobee) in the future.

@aspeake aspeake merged commit f80eac4 into master Aug 10, 2020
joseph-robertson added a commit that referenced this pull request Aug 13, 2020
…48ce2

fa5a0548ce2 BuildResidentialHPXML measure: Shared water heater (#467)
172d03c6995 Add valid_attr method in.
3b91ea5d508 Set shared pv system to false.
ceed3a61bbe Merge branch 'master' into build-res-hpxml-v3
12da8ffe388 Merge pull request #465 from NREL/shared_pv
847006d6f6d Merge pull request #468 from NREL/shared_parking_garages
3312c7c2406 Document "garage" should only be used for single-family garages, not parking garages.
355f856d31a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into shared_pv
c3574d4a681 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into shared_pv
2efe2d0109c First pass.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: fa5a0548ce2df7f21d6caa6b792055a8d21fcb6c
@joseph-robertson joseph-robertson added this to the ResStock v2.4.0 milestone Aug 21, 2020
@joseph-robertson joseph-robertson deleted the update_tsp_distributions branch October 28, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants