Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock-HPXML: Generate schedules #467

Closed
wants to merge 40 commits into from

Conversation

joseph-robertson
Copy link
Contributor

Addresses #[issue number here].

Pull Request Description

[description here]

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing (green) on circleci
  • The changelog has been updated appropriately
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

5c0d553a29 Connect cw and dw to schedule file.
5d03a55359 Connect lighting to schedule file object.
2a161f90af Connect other plug loads to schedule file.
f04f3922f6 Start connecting translator measure to schedule file object.
5440e6b12d Set schedule path in header.
1d92af07e5 Move schedule generation into build measure.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 5c0d553a29a3a8d294999b7f35c1632e0cd9a895
f92ef9b337 Add osw test for vacancy period.
2e5197b646 Add vacancy args to build measure.
6ddce1e8a8 Avoid regenerating schedule when it exists.
0e4cf0103c Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
4e8ead42e6 Merge branch 'master' into build-res-hpxml-v3
59aa54b560 Merge pull request #451 from NREL/change_holiday_lighting_input_requirement
506292fdf4 Run tasks.rb update_measures
1ad267c267 Clean up.
fa0cb26eca Change holiday lighting input requirement

git-subtree-dir: resources/hpxml-measures
git-subtree-split: f92ef9b337c4439687ba90f8b3e721209855044f
2f684b43e2 Set calendar year before schedule generation.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 2f684b43e23229d5f0646e746218fcd5efc171e7
@joseph-robertson joseph-robertson self-assigned this Jul 21, 2020
d44a1af2ef Set vacancy on generation instead of afterwards.
f0c7a123c5 Update vacancy osw to be 6 months.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: d44a1af2effb26d7085f49f33cfbac138ec3fca8
a9cc2aac4a Connect clothes dryer to schedule file.
88f3cdb3bf Connect ceiling fan to schedule file.
9b61aa57c8 Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
3b55d832b8 Merge branch 'master' into build-res-hpxml-v3
f0be9072dc Merge pull request #417 from NREL/ep_warnings
d518fab201 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
4a810c72d0 Merge pull request #445 from NREL/apply_ceiling_construction
ee680de57d Oops, typo.
2b84bdc0e0 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into apply_ceiling_construction
7f6365c27a Set defrost time to zero to clarify that it's not applicable. (Doesn't affect results.)
c0a8ed306f Exclude defrost for heat pumps where fraction heat load served is zero.
8e7675d62b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
3ea0933d0a Minor cleanup. [ci skip]
9841947395 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
be10dc0110 Update filename.
57c4392b4c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
65e5ccb2db Prefer Construction.apply_ceiling over Construction.apply_floor for some situations.
218d00bcec Update warnings.
df8e650e6c Oops, botched the merge.
f512fc55ea Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
3444eca993 Fix GSHP shank spacing -- should be center of pipe to center of pipe, not distance between pipes.
68cb97b535 format
de12375a92 size oa controller to eliminate one warning, justify others for evap cooler
5b6ea2a015 bugfix
7dc37659ce Merge branch 'ep_warnings' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
1ed384ca1a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
e9be7f918e Merge branch 'ep_warnings' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
9f221053bd Prevent surface area warnings.
253f26f182 Update warning. [ci skip]
e7a4176eab format, conflict
6511e08652 improve indirect wh deadband control to reheat to setpoint
e97310c884 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ep_warnings
b21776830e one temp bugfix
bb362a79da combi system warning resolved by updating hx setpoint to be dynamic (small ci diff expected)
b1837f7fc2 Add checks on E+ warnings. Address a couple.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: a9cc2aac4a7fe535a96f62f21fc7280d5a72acaf
bbbeab6c51 Typo in ceiling fan schedule file.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: bbbeab6c5106cc03e694d921cfd27dd8f71dd4dc
b242564579 Another typo in ceiling fan schedule file.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: b2425645793835e802f60e2fc7b1dd61f15f3d66
a35e27334e Set vacancy after calculating design levels.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: a35e27334e94ebd0a0cb227ed1abc4282c7432cb
77e77f0b53 Set vacancy only if schedules are generated.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 77e77f0b532bf00a1f31e5ba3f8d0caf37f1aa79
…1382f

6be8171382f Update epvalidator for schedule fields.
5d065c62ad2 Add fixtures column to exported schedules csv.
3540c7d302f Move fixture schedule names to water heating level.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 6be8171382fba293008ad9cb78cef83cdd752e4b
…aa039

3e8152aa039 Typo.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 3e8152aa0397949a6689864ec3c007fba91af6a4
…e6a04

972105e6a04 Clean up vacancy method.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 972105e6a0436b8977dc6094d79fcbf7d5412f08
…fe0ce

cc0891fe0ce Update the docs.
4e9d0afd389 Clean up a few typos.
c5b036b742f Move schedules into shared resource file.
f6ffbf5812f Change average cd schedule to wkdy, wked, mnthly.
edc8fd34c5e Add average hot water schedules.
35bd54421fa Bit of rearranging.
db46af353db Update epvalidator to have either schedules or schedules path.
80f1103ebe9 Remove schedule column string from epvalidator.
293f09e1558 Add schedules require back in.
5192f03900a Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
417575fd56e Remove stubbed schedules code.
462e3f4717c Few fixes.
da805b4a1ca Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
d02f18e9bc6 Change variable name.
457cc6daab2 Merge branch 'master' into build-res-hpxml-v3
ceb8cc5df70 Rename some test osw files.
55880c0e967 Progress on setting average schedules.
3b8f8af0644 Optionally point to rf, fz, fl, pool, hot tub schedules.
a9784e4face Continue creating average vs stochastic schedules.
79233ddcb8d Get things running.
8cbf74000d9 Merge pull request #456 from NREL/more-warnings
82c127a6d00 Stub test osws with schedule types.
c5e61320557 Remove schedule fields from hpxml.
bf970868e78 Remove fraction and multiplier arguments.
ec2ff1e65f9 Switch to all monthly outputs for tests.
781416f8ade Round workflow time in CI csv.
191b4e80f08 Adds message about run.log for successful simulations.
eaeb40d9a05 Adds more warnings to run.log if common building components (plug loads, lighting, water heater, HVAC, etc.) are not specified.
888bd046baa Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
237e9fd3067 Remove other exterior argument.
ee7c1484fc5 Clean things up.
cfd1f8c29d5 Extend possible other locations.
e4b81287f09 Merge branch 'master' into build-res-hpxml-v3
bd12891da28 Merge pull request #453 from NREL/appliance_mf_locations
6ed53a46b4e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into appliance_mf_locations
a0486bd445e Move scope out of HPXMLtoOS measure documentation and into Intro section. [ci skip]
00548474ccc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into appliance_mf_locations
5d288d4577e Update docs. [ci skip]
2c7fc5a5f0f Update docs. [ci skip]
2b31288c33b Adds error checking for references to MF spaces for SFD buildings. Adds tests.
1be8d89acb1 Use more detailed locations (e.g., "other heated space") instead of just "other" for appliances in SFA/MF buildings.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: cc0891fe0ce25da1c6da039b05826a9ebc69f430
joseph-robertson added a commit that referenced this pull request Aug 13, 2020
…48ce2

fa5a0548ce2 BuildResidentialHPXML measure: Shared water heater (#467)
172d03c6995 Add valid_attr method in.
3b91ea5d508 Set shared pv system to false.
ceed3a61bbe Merge branch 'master' into build-res-hpxml-v3
12da8ffe388 Merge pull request #465 from NREL/shared_pv
847006d6f6d Merge pull request #468 from NREL/shared_parking_garages
3312c7c2406 Document "garage" should only be used for single-family garages, not parking garages.
355f856d31a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into shared_pv
c3574d4a681 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into shared_pv
2efe2d0109c First pass.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: fa5a0548ce2df7f21d6caa6b792055a8d21fcb6c
…dd4e8

170b96dd4e8 Add descriptions for vacancy related arguments.
38344588fc7 Move a comment for exterior lighting weekday fractions.
0c62766af5f Change average to default and improve schedules type arg description.
e23cd8efe12 Point to sample csv instead of listing column names in docs.
38046241c46 Reduce exported schedules csv file size.
dead8c29d7f Modify the csv path hpxml element name.
05db6a119fb Remove the currently unused set_outage method.
e81bc223da7 Replace month/day units with # for run period, dst, and vacancy arguments.
be36291c9fa Remove debugs and fix an issue.
0f115e408d9 More debug.
581234b50eb Print a debug line.
b1323eeeb60 Cleaning up and fixing.
f79f809a8c1 Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
1642b7c13aa Merge branch 'master' into build-res-hpxml-v3
7995f3c61e7 Attempt to diagnose test failure.
7ccecddb88c Fix typos and remove unnecessary test.
6124b082d24 Merge pull request #476 from NREL/shared-clothes-dryer
0b2322ce462 Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
2af1deafcf0 Fix things in hot water resource.
b9b8c28a96c More merge conflicts, 2.
b9dd4d2f5dd More merge conflicts.
97cee84166e Weird merge stuff going on.
70969705e57 Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
b4e08588998 Fix shared clothes dryer input in sample file(s).
4067761c472 Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
39134750d82 Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
3276e9bfd37 Call schedules file class once at top of measure.
1ad02b1630a Use average schedules by defaulting, not schedule csv.
cc0891fe0ce Update the docs.
4e9d0afd389 Clean up a few typos.
c5b036b742f Move schedules into shared resource file.
f6ffbf5812f Change average cd schedule to wkdy, wked, mnthly.
edc8fd34c5e Add average hot water schedules.
35bd54421fa Bit of rearranging.
db46af353db Update epvalidator to have either schedules or schedules path.
80f1103ebe9 Remove schedule column string from epvalidator.
293f09e1558 Add schedules require back in.
5192f03900a Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
462e3f4717c Few fixes.
da805b4a1ca Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
d02f18e9bc6 Change variable name.
55880c0e967 Progress on setting average schedules.
3b8f8af0644 Optionally point to rf, fz, fl, pool, hot tub schedules.
a9784e4face Continue creating average vs stochastic schedules.
79233ddcb8d Get things running.
82c127a6d00 Stub test osws with schedule types.
c5e61320557 Remove schedule fields from hpxml.
bf970868e78 Remove fraction and multiplier arguments.
888bd046baa Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
972105e6a04 Clean up vacancy method.
3e8152aa039 Typo.
6be8171382f Update epvalidator for schedule fields.
5d065c62ad2 Add fixtures column to exported schedules csv.
3540c7d302f Move fixture schedule names to water heating level.
77e77f0b532 Set vacancy only if schedules are generated.
a35e27334e9 Set vacancy after calculating design levels.
b2425645793 Another typo in ceiling fan schedule file.
bbbeab6c510 Typo in ceiling fan schedule file.
a9cc2aac4a7 Connect clothes dryer to schedule file.
88f3cdb3bff Connect ceiling fan to schedule file.
9b61aa57c85 Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
d44a1af2eff Set vacancy on generation instead of afterwards.
f0c7a123c5c Update vacancy osw to be 6 months.
2f684b43e23 Set calendar year before schedule generation.
f92ef9b337c Add osw test for vacancy period.
2e5197b6466 Add vacancy args to build measure.
6ddce1e8a86 Avoid regenerating schedule when it exists.
0e4cf0103cd Merge branch 'build-res-hpxml-v3' into build-res-hpxml-v3-schedule-files
5c0d553a29a Connect cw and dw to schedule file.
5d03a55359a Connect lighting to schedule file object.
2a161f90af5 Connect other plug loads to schedule file.
f04f3922f6a Start connecting translator measure to schedule file object.
5440e6b12d3 Set schedule path in header.
1d92af07e52 Move schedule generation into build measure.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 170b96dd4e8cfd56adc607d0827a057db3b5dabf
…c1702

716ffcc1702 Small fix for default schedules type.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 716ffcc170221d57d69ca3a9ffdd57a76e451a89
@joseph-robertson joseph-robertson deleted the restructure-v3-schedule-files branch October 6, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant