Fix: All buildings have double-loaded corridors

[afontani]

Pull Request Description

Problem

In the project_national/housing_characteristics/Corridor.tsv, all buildings are assigned a "Double-Loaded Corridor." However, the single-family detached, mobile homes, and single-family attached buildings do not have corridors. For single-family detached, mobile homes, and single-family attached buildings, measures/BuildExistingModel/measure.rb removes the calls to the ResidentialGeometryCreateMultifamily measure.

This workflow creates a column in the buildstock.csv and results.csv that says all buildings have a double-loaded corridor.

Fix

For transparency, a new option is introduced "Option=Not Applicable" where all single-family detached, mobile-homes, and single-family detached are assigned. All multi-family buildings still have a double-loaded corridor. This change makes the Corridor column in the buildstock.csv and results.csv a little more informative and transparent.

There are no changes to the simulated models, therefore there are no energy impacts of this change.

Checklist

Not all may apply:

• Unit tests have been added or updated
• All rake tasks have been run, and pass
• Documentation has been modified appropriately
• Any new options are added to project_testing
• project_testing runs without any failures
• No unexpected regression test changes
• All tests are passing (green) on circleci
• The changelog has been updated appropriately
• This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

[joseph-robertson]

@afontani Do you want to try a quick test run to make sure everything shows up as expected in the buildstock/results csv?

[joseph-robertson]

Do we need a companion PR on resstock-estimation for these tsv changes?

[afontani]

@joseph-robertson: So I ran some tests and saw that there are some reproducibility issues with our simulations corresponding to some measures, but this PR should not be the reason for the reproducibility issue.

In terms of resstock-estimation, This housing characteristic is not scripted and does not exist in the resstock-estimation repo. So I don't think we need a companion PR.

[joseph-robertson]

@afontani I'm sort of confused why integrity checks still pass. Aren't we now lacking assignment of corridor_position and corridor_width for the ResidentialGeometryCreateMultifamily measure? Even when the sample is single-family detached, the ResidentialGeometryCreateMultifamily measure is referenced by, e.g., Bedrooms.