-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: All buildings have double-loaded corridors #522
Conversation
…RECS dependency In the buildstock.csv and results.csv all buildings have a double-loaded corridor. This change has no energy impacts, but is more transparent about which buildings have corridors.
@afontani Do you want to try a quick test run to make sure everything shows up as expected in the buildstock/results csv? |
fix bug with infiltration load calcs in sizing [ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a companion PR on resstock-estimation for these tsv changes?
@joseph-robertson: So I ran some tests and saw that there are some reproducibility issues with our simulations corresponding to some measures, but this PR should not be the reason for the reproducibility issue. In terms of resstock-estimation, This housing characteristic is not scripted and does not exist in the resstock-estimation repo. So I don't think we need a companion PR. |
@afontani I'm sort of confused why integrity checks still pass. Aren't we now lacking assignment of |
Pull Request Description
Problem
In the
project_national/housing_characteristics/Corridor.tsv
, all buildings are assigned a "Double-Loaded Corridor." However, the single-family detached, mobile homes, and single-family attached buildings do not have corridors. For single-family detached, mobile homes, and single-family attached buildings,measures/BuildExistingModel/measure.rb
removes the calls to theResidentialGeometryCreateMultifamily
measure.This workflow creates a column in the
buildstock.csv
andresults.csv
that says all buildings have a double-loaded corridor.Fix
For transparency, a new option is introduced "Option=Not Applicable" where all single-family detached, mobile-homes, and single-family detached are assigned. All multi-family buildings still have a double-loaded corridor. This change makes the Corridor column in the
buildstock.csv
andresults.csv
a little more informative and transparent.There are no changes to the simulated models, therefore there are no energy impacts of this change.
Checklist
Not all may apply:
project_testing
project_testing
runs without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.