Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against double subscription #77

Merged

Conversation

danielballan
Copy link
Contributor

Closes #76

@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #77 into master will increase coverage by 4.29%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   48.05%   52.34%   +4.29%     
==========================================
  Files          13       13              
  Lines         720      724       +4     
==========================================
+ Hits          346      379      +33     
+ Misses        374      345      -29
Impacted Files Coverage Δ
nslsii/__init__.py 6.76% <0%> (-0.21%) ⬇️
nslsii/_version.py 44.4% <0%> (+1.8%) ⬆️
nslsii/tests/temperature_controllers_test.py 100% <0%> (+33.33%) ⬆️
nslsii/temperature_controllers.py 91.83% <0%> (+36.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1545ae6...f2b597c. Read the comment docs.

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@tacaswell
Copy link
Member

I think it would be better to stash this in the namespace passed into configure_base, not in the nslsii module.

@danielballan
Copy link
Contributor Author

True. That approach is better because it allows for the possibility of running multiple times as long as the namespaces are separate (good for tests) and it works even if the user does reload(nslsii).

nslsii/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as the syntax error is resolved.

Co-Authored-By: K Lauer <klauer@users.noreply.github.com>
@tacaswell tacaswell merged commit ee11542 into NSLS-II:master Feb 14, 2020
@danielballan danielballan deleted the protect-against-double-subscription branch February 15, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid double subscription of databroker to RE
5 participants