-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect against double subscription #77
Protect against double subscription #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 48.05% 52.34% +4.29%
==========================================
Files 13 13
Lines 720 724 +4
==========================================
+ Hits 346 379 +33
+ Misses 374 345 -29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround!
I think it would be better to stash this in the namespace passed into |
True. That approach is better because it allows for the possibility of running multiple times as long as the namespaces are separate (good for tests) and it works even if the user does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as long as the syntax error is resolved.
Closes #76