Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a filestore mixin to be used with AD hdf5 plugin in Single mode #623

Merged
merged 1 commit into from
Nov 21, 2018
Merged

add a filestore mixin to be used with AD hdf5 plugin in Single mode #623

merged 1 commit into from
Nov 21, 2018

Conversation

awalter-bnl
Copy link
Contributor

Description:

This PR adds a new filestore mixin that should be used to run an Area Detector HDF5_plugin in Single mode instead of Streaming mode. The result of this mode is that a new hdf5 file is created for every trigger.It also adds a second filestore plugin that mixes into this the FileStoreIterativeWrite plugin.

Motivation:

This was motivated by a custom plugin which has an array with one dimension determined only after running the plugin The result is that each trigger then creates a different sized array to the previous one, and so the Streaming mode which sets the array size prior to any trigger did not correctly save the data.

Testing:

This has been tested in the field as submitted here (NSLS-II, SIX beamline, rixscam detector, XIP plugin) and is working there.

@awalter-bnl
Copy link
Contributor Author

The failure here is in the nightly test and is related to a caproto timeout error. I don't think that the current change touches that.

@klauer
Copy link
Member

klauer commented Nov 16, 2018

I don't see any major issues with this, except:

This was motivated by a custom plugin

Based on that, it seems like this may be better off in the nslsii package (or in the SIX beamline config?).
What plugin is it?

@awalter-bnl
Copy link
Contributor Author

Thanks for the comment @klauer. In response:

  1. While this was motivated by a custom plugin, that plugin just does some on the fly processing. This custom plugin uses the standard AD-HDF5 file plugin.
  2. This filestore mixin works with the standard AD-HDF5 file plugin, but running in 'single' mode (one file per trigger) as opposed to 'streaming mode' (1 file per run) which the current hdf5 filestore mixin works with.
    As this works with the standard AD-HDF5 plugin, but in a different mode to the current one, I think it has general appeal. If it is decided that it doesn't we currently already have this in nslsii and deployed.

@klauer
Copy link
Member

klauer commented Nov 20, 2018

@awalter-bnl OK, I see no other reason to not merge this from my perspective.

Objections? Will merge by Pacific COB if none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants