Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with import httpx wrapper instance #95

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Fix issue with import httpx wrapper instance #95

merged 6 commits into from
Jun 5, 2024

Conversation

stuartcampbell
Copy link
Collaborator

Also included some minor cosmetic log changes.

@stuartcampbell stuartcampbell added the bug Something isn't working label Jun 4, 2024
@stuartcampbell stuartcampbell self-assigned this Jun 4, 2024
Kezzsim
Kezzsim approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@Kezzsim Kezzsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing out of the ordinary, mostly minor linter and stylistic improvements. The httpx wrapper looks good.

@stuartcampbell
Copy link
Collaborator Author

self merging as @Kezzsim seems happy 😄

@stuartcampbell stuartcampbell merged commit b6ee312 into NSLS2:main Jun 5, 2024
1 check passed
@stuartcampbell stuartcampbell deleted the cosmetic-log-changes branch June 5, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kezzsim Kezzsim Kezzsim approved these changes

@danielballan danielballan Awaiting requested review from danielballan

Assignees

@stuartcampbell stuartcampbell

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stuartcampbell @Kezzsim