Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSFontFaceRule is missing from npm package exports #97

Closed
amitzur opened this issue Jul 1, 2018 · 4 comments
Closed

CSSFontFaceRule is missing from npm package exports #97

amitzur opened this issue Jul 1, 2018 · 4 comments

Comments

@amitzur
Copy link
Contributor

amitzur commented Jul 1, 2018

versions 0.3.2 and 0.3.3 are missing CSSFontFaceRule from exports.
I couldn't find it in the source code, as tags for these versions don't exists.

For reference, here's the contents of index.js for v0.3.3:

exports.CSSStyleDeclaration = require("./CSSStyleDeclaration").CSSStyleDeclaration;
exports.CSSRule = require("./CSSRule").CSSRule;
exports.CSSStyleRule = require("./CSSStyleRule").CSSStyleRule;
exports.CSSImportRule = require("./CSSImportRule").CSSImportRule;
exports.MediaList = require("./MediaList").MediaList;
exports.CSSMediaRule = require("./CSSMediaRule").CSSMediaRule;
exports.StyleSheet = require("./StyleSheet").StyleSheet;
exports.CSSStyleSheet = require("./CSSStyleSheet").CSSStyleSheet;
exports.parse = require("./parse").parse;
exports.clone = require("./clone").clone;
@amitzur
Copy link
Contributor Author

amitzur commented Jul 3, 2018

I'd happily create a PR, but it's not an issue in the code in master, and I'm not sure where the change that created this issue was introduced

@NV
Copy link
Owner

NV commented Jul 3, 2018

Please check v0.3.4 that I just released.

I apologize I no longer actively maintain CSSOM. I didn't remember how index.js was generated, so I just added it to the repo and manually put CSSFontFaceRule in there. The build system is terribly outdated and should be improved.

@amitzur
Copy link
Contributor Author

amitzur commented Jul 3, 2018

I did something similar in a fork. The difference is I ran the actual build so I also got more objects inside like CSSSupportsRule which I needed.

Thanks for your effort although you're not actively maintaining this!

@NV
Copy link
Owner

NV commented Jul 7, 2018

Fixed in #98.

@NV NV closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants