Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the get_component_init_parameters to class_utils #2578

Merged
merged 3 commits into from
May 15, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented May 14, 2024

Fixes # .

Description

Moved the get_component_init_parameters to class_utils for sharing function.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add docstrings and unit test cases for get_component_init_parameters.

nvflare/fuel/utils/class_utils.py Show resolved Hide resolved
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful!

Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerroth
Copy link
Collaborator

/build

@holgerroth holgerroth enabled auto-merge (squash) May 15, 2024 21:36
@holgerroth holgerroth merged commit 70c385e into NVIDIA:main May 15, 2024
16 checks passed
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request May 22, 2024
* Moved the get_component_init_parameters to class_utils.

* added docstring and unit test.

---------

Co-authored-by: Holger Roth <6304754+holgerroth@users.noreply.github.com>
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
* Moved the get_component_init_parameters to class_utils.

* added docstring and unit test.

---------

Co-authored-by: Holger Roth <6304754+holgerroth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants