-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved the get_component_init_parameters to class_utils #2578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please add docstrings and unit test cases for get_component_init_parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/build |
* Moved the get_component_init_parameters to class_utils. * added docstring and unit test. --------- Co-authored-by: Holger Roth <6304754+holgerroth@users.noreply.github.com>
* Moved the get_component_init_parameters to class_utils. * added docstring and unit test. --------- Co-authored-by: Holger Roth <6304754+holgerroth@users.noreply.github.com>
Fixes # .
Description
Moved the get_component_init_parameters to class_utils for sharing function.
Types of changes
./runtest.sh
.