Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bias act fusion #4376

Merged
merged 13 commits into from
Jun 30, 2022
Merged

Refactor bias act fusion #4376

merged 13 commits into from
Jun 30, 2022

Conversation

MaximumEntropy
Copy link
Contributor

Signed-off-by: MaximumEntropy sandeep.subramanian.1@umontreal.ca

What does this PR do ?

Refactors bias activation fusion logic and adds the config option to the remaining yaml files.

Collection: [Note which collection this PR will affect]

Changelog

  • Adds/replaces bias_gelu_fusion with bias_activation_fusion in remaining yaml configs.
  • Refactors some of the logic within transformer.py and lm_encoder_decoder.py.

Usage

N/A

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2022

This pull request fixes 1 alert when merging fec4763 into 98f8988 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2022

This pull request fixes 1 alert when merging bb87904 into 31099f4 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2022

This pull request fixes 1 alert when merging e6c5347 into a9c0cab - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2022

This pull request fixes 1 alert when merging f304ca6 into 76ae9b5 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 21, 2022

This pull request fixes 1 alert when merging bf433c0 into faaf02f - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 25, 2022

This pull request fixes 1 alert when merging 6f6649a into 592e5c2 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lgtm-com
Copy link

lgtm-com bot commented Jun 27, 2022

This pull request fixes 1 alert when merging f683bce into 794743e - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2022

This pull request fixes 1 alert when merging 2f83b69 into 794743e - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2022

This pull request fixes 1 alert when merging 5f7ed3f into d985ebc - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2022

This pull request fixes 1 alert when merging ee153e0 into 6219718 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 30, 2022

This pull request fixes 1 alert when merging 43ffc76 into bb5c59f - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@ericharper ericharper merged commit 7e53b32 into r1.10.0 Jun 30, 2022
@ericharper ericharper deleted the bias_act_fusion_refactor branch June 30, 2022 02:39
ericharper pushed a commit that referenced this pull request Jul 1, 2022
* Refactor bias act fusion

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update NMT config

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update ci tests

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Empty

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
ericharper added a commit that referenced this pull request Jul 1, 2022
* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* Fix ASR Typos in tutorials (#4384)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383)

Signed-off-by: tbartley94 <tbartley@nvidia.com>

Co-authored-by: tbartley94 <tbartley@nvidia.com>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <Travismbartley@gmail.com>

* Fix tutorial typos and docs (#4415)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Scores to Docs (#4412)

* Fix link

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Correct model card

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Results to Docs

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* docs: add table overflow handling for nested sections (#4441)

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Docs: Decrease Font Size on Tables  (#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Updated notebook to fix batch configuration and precision bugs (#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Deleted cell outputs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* fix branch in link (#4454)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add measure units to serial

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* fix test case

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* update indentation (#4468)

Signed-off-by: Akshit Arora <akshit.arora@colorado.edu>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469)

Signed-off-by: Hoo Chang Shin <hshin@nvidia.com>

Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>

* Fix some 's' cases for IPA G2P (#4460)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Refactor bias act fusion (#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update NMT config

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update ci tests

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Empty

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Add kwargs to exact string match (#4479)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Try fix (#4484)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Travis Bartley <Travismbartley@gmail.com>
Co-authored-by: Nick Goncharenko <8766167+nickolyamba@users.noreply.github.com>
Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Akshit Arora <akshit.arora@colorado.edu>
Co-authored-by: khcs <khcs@users.noreply.github.com>
Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
XuesongYang pushed a commit that referenced this pull request Jul 5, 2022
* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* Fix ASR Typos in tutorials (#4384)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383)

Signed-off-by: tbartley94 <tbartley@nvidia.com>

Co-authored-by: tbartley94 <tbartley@nvidia.com>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <Travismbartley@gmail.com>

* Fix tutorial typos and docs (#4415)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Scores to Docs (#4412)

* Fix link

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Correct model card

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Results to Docs

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* docs: add table overflow handling for nested sections (#4441)

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Docs: Decrease Font Size on Tables  (#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Updated notebook to fix batch configuration and precision bugs (#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Deleted cell outputs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* fix branch in link (#4454)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add measure units to serial

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* fix test case

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* update indentation (#4468)

Signed-off-by: Akshit Arora <akshit.arora@colorado.edu>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469)

Signed-off-by: Hoo Chang Shin <hshin@nvidia.com>

Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>

* Fix some 's' cases for IPA G2P (#4460)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Refactor bias act fusion (#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update NMT config

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update ci tests

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Empty

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Add kwargs to exact string match (#4479)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Try fix (#4484)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Travis Bartley <Travismbartley@gmail.com>
Co-authored-by: Nick Goncharenko <8766167+nickolyamba@users.noreply.github.com>
Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Akshit Arora <akshit.arora@colorado.edu>
Co-authored-by: khcs <khcs@users.noreply.github.com>
Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
arendu pushed a commit that referenced this pull request Jul 21, 2022
* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* Fix ASR Typos in tutorials (#4384)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383)

Signed-off-by: tbartley94 <tbartley@nvidia.com>

Co-authored-by: tbartley94 <tbartley@nvidia.com>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <Travismbartley@gmail.com>

* Fix tutorial typos and docs (#4415)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Scores to Docs (#4412)

* Fix link

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Correct model card

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Results to Docs

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* docs: add table overflow handling for nested sections (#4441)

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Docs: Decrease Font Size on Tables  (#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Updated notebook to fix batch configuration and precision bugs (#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Deleted cell outputs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* fix branch in link (#4454)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add measure units to serial

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* fix test case

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* update indentation (#4468)

Signed-off-by: Akshit Arora <akshit.arora@colorado.edu>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469)

Signed-off-by: Hoo Chang Shin <hshin@nvidia.com>

Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>

* Fix some 's' cases for IPA G2P (#4460)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Refactor bias act fusion (#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update NMT config

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update ci tests

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Empty

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Add kwargs to exact string match (#4479)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Try fix (#4484)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Travis Bartley <Travismbartley@gmail.com>
Co-authored-by: Nick Goncharenko <8766167+nickolyamba@users.noreply.github.com>
Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Akshit Arora <akshit.arora@colorado.edu>
Co-authored-by: khcs <khcs@users.noreply.github.com>
Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: arendu <adithya.r@gmail.com>
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* Fix ASR Typos in tutorials (NVIDIA#4384)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383)

Signed-off-by: tbartley94 <tbartley@nvidia.com>

Co-authored-by: tbartley94 <tbartley@nvidia.com>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <Travismbartley@gmail.com>

* Fix tutorial typos and docs (NVIDIA#4415)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Scores to Docs (NVIDIA#4412)

* Fix link

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Correct model card

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Results to Docs

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* docs: add table overflow handling for nested sections (NVIDIA#4441)

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Docs: Decrease Font Size on Tables  (NVIDIA#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Deleted cell outputs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* fix branch in link (NVIDIA#4454)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (NVIDIA#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (NVIDIA#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add measure units to serial

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* fix test case

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* update indentation (NVIDIA#4468)

Signed-off-by: Akshit Arora <akshit.arora@colorado.edu>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (NVIDIA#4469)

Signed-off-by: Hoo Chang Shin <hshin@nvidia.com>

Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>

* Fix some 's' cases for IPA G2P (NVIDIA#4460)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Refactor bias act fusion (NVIDIA#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update NMT config

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update ci tests

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Empty

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Add kwargs to exact string match (NVIDIA#4479)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Try fix (NVIDIA#4484)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Travis Bartley <Travismbartley@gmail.com>
Co-authored-by: Nick Goncharenko <8766167+nickolyamba@users.noreply.github.com>
Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Akshit Arora <akshit.arora@colorado.edu>
Co-authored-by: khcs <khcs@users.noreply.github.com>
Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* Fix ASR Typos in tutorials (NVIDIA#4384)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383)

Signed-off-by: tbartley94 <tbartley@nvidia.com>

Co-authored-by: tbartley94 <tbartley@nvidia.com>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <Travismbartley@gmail.com>

* Fix tutorial typos and docs (NVIDIA#4415)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Scores to Docs (NVIDIA#4412)

* Fix link

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Correct model card

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Results to Docs

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* docs: add table overflow handling for nested sections (NVIDIA#4441)

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Docs: Decrease Font Size on Tables  (NVIDIA#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Deleted cell outputs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* fix branch in link (NVIDIA#4454)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (NVIDIA#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (NVIDIA#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add measure units to serial

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* fix test case

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* update indentation (NVIDIA#4468)

Signed-off-by: Akshit Arora <akshit.arora@colorado.edu>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (NVIDIA#4469)

Signed-off-by: Hoo Chang Shin <hshin@nvidia.com>

Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>

* Fix some 's' cases for IPA G2P (NVIDIA#4460)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Refactor bias act fusion (NVIDIA#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update NMT config

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update ci tests

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Empty

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Add kwargs to exact string match (NVIDIA#4479)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Try fix (NVIDIA#4484)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Travis Bartley <Travismbartley@gmail.com>
Co-authored-by: Nick Goncharenko <8766167+nickolyamba@users.noreply.github.com>
Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Akshit Arora <akshit.arora@colorado.edu>
Co-authored-by: khcs <khcs@users.noreply.github.com>
Co-authored-by: Hoo Chang Shin <hshin@nvidia.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants