-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedding_bag operator on GPU #3319
Comments
@nvpohanh ^ ^ |
For Gather operation, TRT generates the kernel dynamically and tries to fuse it with other pointwise operations if possible. That means, we do not use the same Gather kernels as PyTorch does. |
Our MLPerf-Inference submission uses TensorRT for the DLRM benchmark: https://github.com/mlcommons/inference_results_v3.1/tree/main/closed/NVIDIA Using TensorRT allows more aggressive fusions like Gemm+Pointwise fusions. |
closing since no activity for more than 3 weeks, thanks all! |
Thanks @nvpohanh for the comments. Could you share the source code for TRT implementation of Gather Kernel used in Embedding Stage for DLRMs? Also, could you compare the TRT gather kernel with the PyTorch Embedding Stage CUDA kernel (link) |
@nvpohanh ^ ^ |
Hi -- could you please share your comments on my follow-up question? Thanks. |
Hello,
Nvidia MLPerf suggests to use TensorRT framework for a performant inference deployment. For DLRM (DL based Recommendation Systems) inference on GPU, I have the following questions:
Does TensorRT modify the backend (CUDA/C++ source code) of Embedding bag operator or it uses the exact same vanilla PyTorch CUDA kernels?
What are the benefits of using vanilla PyTorch over TensorRT for DLRM inference?
Please let me know your comments. Thanks
The text was updated successfully, but these errors were encountered: