Remove remaining C++03 compatibility from unit tests #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. This patch removes all remaining checks against C++03 which were left after NVIDIA#378. This patch relates to NVIDIA#127 and NVIDIA#378.
|
/ok to test |
|
/ok to test |
miscco
reviewed
Jan 17, 2024
libcudacxx/libcxx/test/libcxx/iterators/trivial_iterators.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp
Show resolved
Hide resolved
|
/ok to test |
|
You addressed all comments from your review in your commit, or? So nothing left to do? |
|
Only addressing the merge conflics I just introduces :) |
|
/ok to test |
miscco
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #127, code for unsupported compilation modes/platforms will be removed. This patch removes all remaining checks against C++03 which were left after #378.
This patch relates to #127 and #378.
Checklist