-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove C++03 compatability from unit tests #378
Conversation
Pull requests from external contributors require approval from a |
To reduce the size of this PR, I would remove the test macros like |
/ok to test |
As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. In alignment with this goal, the present patch remove all checks against C++03 and the corresponding code from the unit test located under `.upstream-test/`. This patch relates to NVIDIA#127.
a3271e8
to
12ac6c8
Compare
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I think I found one incorrect conditional but otherwise this looks great 🚀
#if !(defined(TEST_COMPILER_MSVC) && defined(_LIBCUDACXX_USE_IS_CONVERTIBLE_FALLBACK)) && \ | ||
(TEST_STD_VER >= 11 || !defined(_LIBCUDACXX_USE_IS_CONVERTIBLE_FALLBACK)) | ||
(!defined(_LIBCUDACXX_USE_IS_CONVERTIBLE_FALLBACK)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that is not correct. The condition was ||
so it was always true
/ok to test |
As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. This patch removes all remaining checks against C++03 which were left after NVIDIA#378. This patch relates to NVIDIA#127 and NVIDIA#378.
As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. This patch removes all remaining checks against C++03 which were left after NVIDIA#378. This patch relates to NVIDIA#127 and NVIDIA#378.
* Remove remaining C++03 compatibility from unit tests As part of #127, code for unsupported compilation modes/platforms will be removed. This patch removes all remaining checks against C++03 which were left after #378. This patch relates to #127 and #378. --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
As part of #127, code for unsupported compilation modes/platforms will be removed. In alignment with this goal, the present patch remove all checks against C++03 and the corresponding code from the unit test located under
.upstream-test/
.This patch relates to #127
Checklist