Remove C++03 compatability from unit tests #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blonck
requested review from
miscco and
elstehle
and removed request for
a team
|
Pull requests from external contributors require approval from a |
|
To reduce the size of this PR, I would remove the test macros like |
|
/ok to test |
As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. In alignment with this goal, the present patch remove all checks against C++03 and the corresponding code from the unit test located under `.upstream-test/`. This patch relates to NVIDIA#127.
Blonck
force-pushed
the
remove_cpp03_unit_tests
branch
from
a3271e8
to
12ac6c8
Compare
|
/ok to test |
miscco
reviewed
Sep 13, 2023
Comment on lines
262
to
263
| #if !(defined(TEST_COMPILER_MSVC) && defined(_LIBCUDACXX_USE_IS_CONVERTIBLE_FALLBACK)) && \ | ||
| (TEST_STD_VER >= 11 || !defined(_LIBCUDACXX_USE_IS_CONVERTIBLE_FALLBACK)) | ||
| (!defined(_LIBCUDACXX_USE_IS_CONVERTIBLE_FALLBACK)) |
There was a problem hiding this comment.
I believe that is not correct. The condition was || so it was always true
|
/ok to test |
miscco
approved these changes
Sep 18, 2023
Blonck
added a commit
to Blonck/cccl
that referenced
this pull request
Dec 15, 2023
As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. This patch removes all remaining checks against C++03 which were left after NVIDIA#378. This patch relates to NVIDIA#127 and NVIDIA#378.
Blonck
added a commit
to Blonck/cccl
that referenced
this pull request
Dec 18, 2023
As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. This patch removes all remaining checks against C++03 which were left after NVIDIA#378. This patch relates to NVIDIA#127 and NVIDIA#378.
1 task
miscco
added a commit
that referenced
this pull request
Jan 18, 2024
* Remove remaining C++03 compatibility from unit tests As part of #127, code for unsupported compilation modes/platforms will be removed. This patch removes all remaining checks against C++03 which were left after #378. This patch relates to #127 and #378. --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #127, code for unsupported compilation modes/platforms will be removed. In alignment with this goal, the present patch remove all checks against C++03 and the corresponding code from the unit test located under
.upstream-test/.This patch relates to #127
Checklist