Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Remove unsupported configurations from libcu++ #127

Open
1 task done
miscco opened this issue Jun 28, 2023 · 0 comments
Open
1 task done

[FEA]: Remove unsupported configurations from libcu++ #127

miscco opened this issue Jun 28, 2023 · 0 comments
Labels
feature request New feature or request. good first issue Good for newcomers. libcu++ For all items related to libcu++

Comments

@miscco
Copy link
Collaborator

miscco commented Jun 28, 2023

Is this a duplicate?

Component

libcu++

Is your feature request related to a problem? Please describe.

Due to historical reasons, we have a ton of cruft in the code base. This comes from libc++ supporting compilation modes / platform that we do not support. This includes (not exhausting):

  • Conditional noexcept support.
    • We do not support any standard prior to C++11 so noexcept is supported by all compilers we target
  • C++03 support
    • There is a significant amount of churn around this, as it prevents usage of usingdeclarations and variadics
  • Unsupported platforms such as SUN / IBM

Describe the solution you'd like

We should identify unneeded configurations and remove them to reduce code complexity

Describe alternatives you've considered

We can leave everything as is, as long as we remember why we are doing it.

Additional context

No response
@miscco miscco mentioned this issue Jun 28, 2023
Merged
@miscco miscco added feature request New feature or request. good first issue Good for newcomers. libcu++ For all items related to libcu++ labels Jul 12, 2023
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 16, 2023
Remove _NOEXCEPT macro in favor of noexcept for libcu++
eb6f036 
As part of NVIDIA#127 code for
unsupported compilation modes/platforms will be removed.

`noexcept` is supported by all targeted compilers so the conditional
support can be removed.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 16, 2023
Remove _NOEXCEPT macro in favor of noexcept for libcu++
bc23b42 
As part of NVIDIA#127 code for
unsupported compilation modes/platforms will be removed.

`noexcept` is supported by all targeted compilers so the conditional
support can be removed.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 17, 2023
Remove _NOEXCEPT macro in favor of noexcept for libcu++
70efc92 
As part of NVIDIA#127 code for
unsupported compilation modes/platforms will be removed.

`noexcept` is supported by all targeted compilers so the conditional
support can be removed.
@Blonck Blonck mentioned this issue Aug 17, 2023
Merged
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 18, 2023
Remove _NOEXCEPT macro in favor of noexcept for libcu++
3074b54 
As part of NVIDIA#127 code for
unsupported compilation modes/platforms will be removed.

`noexcept` is supported by all targeted compilers so the conditional
support can be removed.
miscco pushed a commit that referenced this issue Aug 21, 2023
@miscco
Remove _NOEXCEPT macro in favor of noexcept for libcu++
486e557 
As part of #127 code for
unsupported compilation modes/platforms will be removed.

`noexcept` is supported by all targeted compilers so the conditional
support can be removed.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 21, 2023
Use default, constexpr, and delete directly instead of corresponding …
5d2dd83 
…macros

As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed.
`default`, `constexpr`, and `delete` are supported by all targeted compilers, so the conditional support can be removed.

All `_LIBCUDACXX_CONSTEXPR` macros are replaced by `constexpr`.
All `_LIBCUDACXX_EQUAL_DEFAULT` macros are replaced by `= default;`.
All `_LIBCUDACXX_EQUAL_DELETE` macros are replaced by `= delete;`.
@Blonck Blonck mentioned this issue Aug 21, 2023
Merged
1 task
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 22, 2023
Use default, constexpr, and delete directly instead of corresponding …
18ff126 
…macros

As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed.
`default`, `constexpr`, and `delete` are supported by all targeted compilers, so the conditional support can be removed.

All `_LIBCUDACXX_CONSTEXPR` macros are replaced by `constexpr`.
All `_LIBCUDACXX_EQUAL_DEFAULT` macros are replaced by `= default;`.
All `_LIBCUDACXX_EQUAL_DELETE` macros are replaced by `= delete;`.
miscco pushed a commit that referenced this issue Aug 23, 2023
@miscco
Use default, constexpr, and delete directly instead of corresponding …
8b7043c 
…macros

As part of #127, code for unsupported compilation modes/platforms will be removed.
`default`, `constexpr`, and `delete` are supported by all targeted compilers, so the conditional support can be removed.

All `_LIBCUDACXX_CONSTEXPR` macros are replaced by `constexpr`.
All `_LIBCUDACXX_EQUAL_DEFAULT` macros are replaced by `= default;`.
All `_LIBCUDACXX_EQUAL_DELETE` macros are replaced by `= delete;`.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 23, 2023
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code
3f09688 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 23, 2023
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code
50b656a 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.
@Blonck Blonck mentioned this issue Aug 23, 2023
Merged
1 task
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 23, 2023
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code
34e2821 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 24, 2023
Remove __functional_03 and __functional_base_03
f6f7724 
This patch relates to NVIDIA#127.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 24, 2023
Remove __functional_03 and __functional_base_03
736736b 
This patch relates to NVIDIA#127.
miscco pushed a commit that referenced this issue Aug 25, 2023
@Blonck
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code (#368)
b6441ee 
* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of #127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to #127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 25, 2023
Remove checks against _LIBCUDACXX_STD_VER < 11
eb08da8 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 25, 2023
Remove checks against _LIBCUDACXX_STD_VER < 11
c5c0f7a 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.
@Blonck Blonck mentioned this issue Aug 25, 2023
Merged
1 task
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 28, 2023
Remove checks against _LIBCUDACXX_STD_VER < 11
7d1f4c0 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 28, 2023
Remove C++03 compatability from unit tests
7975571 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. This patch removes all checks against C++03 and the corresponding code
from the unit test located under `.upstream-test/`.

This patch relates to NVIDIA#127.
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 28, 2023
Remove C++03 compatability from unit tests
c2fb85f 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. This patch removes all checks against C++03 and the corresponding code
from the unit test located under `.upstream-test/`.

This patch relates to NVIDIA#127.
miscco pushed a commit that referenced this issue Aug 28, 2023
@Blonck
Remove checks against _LIBCUDACXX_STD_VER < 11 (#375)
11b9ced 
As part of #127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 28, 2023
Remove C++03 compatability from unit tests
a3271e8 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. In alignment with this goal, the present patch remove all
checks against C++03 and the corresponding code from the unit test
located under `.upstream-test/`.

This patch relates to NVIDIA#127.
@Blonck Blonck mentioned this issue Aug 28, 2023
Merged
1 task
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 28, 2023
@Blonck @ahendriksen
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code (NVIDIA…
f35ad5f 
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 28, 2023
@Blonck @ahendriksen
Remove checks against _LIBCUDACXX_STD_VER < 11 (NVIDIA#375)
567562d 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 28, 2023
@Blonck @ahendriksen
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code (NVIDIA…
63f765d 
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 28, 2023
@Blonck @ahendriksen
Remove checks against _LIBCUDACXX_STD_VER < 11 (NVIDIA#375)
e7ca2a0 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 29, 2023
@Blonck @ahendriksen
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code (NVIDIA…
c79f2f0 
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 29, 2023
@Blonck @ahendriksen
Remove checks against _LIBCUDACXX_STD_VER < 11 (NVIDIA#375)
c994485 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 29, 2023
@Blonck @ahendriksen
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code (NVIDIA…
722a69e 
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 29, 2023
@Blonck @ahendriksen
Remove checks against _LIBCUDACXX_STD_VER < 11 (NVIDIA#375)
f6a3f7d 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
alliepiper pushed a commit to alliepiper/cccl that referenced this issue Aug 30, 2023
@alliepiper
Remove _NOEXCEPT macro in favor of noexcept for libcu++
558198e 
As part of NVIDIA#127 code for
unsupported compilation modes/platforms will be removed.

`noexcept` is supported by all targeted compilers so the conditional
support can be removed.
alliepiper pushed a commit to alliepiper/cccl that referenced this issue Aug 30, 2023
@alliepiper
Use default, constexpr, and delete directly instead of corresponding …
8319351 
…macros

As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed.
`default`, `constexpr`, and `delete` are supported by all targeted compilers, so the conditional support can be removed.

All `_LIBCUDACXX_CONSTEXPR` macros are replaced by `constexpr`.
All `_LIBCUDACXX_EQUAL_DEFAULT` macros are replaced by `= default;`.
All `_LIBCUDACXX_EQUAL_DELETE` macros are replaced by `= delete;`.
alliepiper pushed a commit to alliepiper/cccl that referenced this issue Aug 30, 2023
@Blonck @alliepiper
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code (NVIDIA…
1d1dc56 
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
Blonck pushed a commit to Blonck/cccl that referenced this issue Aug 31, 2023
Remove C++03 compatability from unit tests
12ac6c8 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. In alignment with this goal, the present patch remove all
checks against C++03 and the corresponding code from the unit test
located under `.upstream-test/`.

This patch relates to NVIDIA#127.
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 31, 2023
@Blonck @ahendriksen
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code (NVIDIA…
96bff14 
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this issue Aug 31, 2023
@Blonck @ahendriksen
Remove checks against _LIBCUDACXX_STD_VER < 11 (NVIDIA#375)
8517b8a 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_STD_VER` macro defines which C++ standard is
used. This patch removes all checks against C++ versions before 11 and
the corresponding code.

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
miscco pushed a commit that referenced this issue Sep 18, 2023
@Blonck
Remove C++03 compatability from unit tests (#378)
54f75d4 
* Remove C++03 compatability from unit tests

As part of #127, code for unsupported compilation modes/platforms will
be removed. In alignment with this goal, the present patch remove all
checks against C++03 and the corresponding code from the unit test
located under `.upstream-test/`.

This patch relates to #127.

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
Blonck added a commit to Blonck/cccl that referenced this issue Dec 15, 2023
@Blonck
Remove remaining C++03 compatibility from unit tests
5fa1825 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. This patch removes all remaining checks against C++03 which
were left after NVIDIA#378.

This patch relates to NVIDIA#127 and NVIDIA#378.
Blonck added a commit to Blonck/cccl that referenced this issue Dec 18, 2023
@Blonck
Remove remaining C++03 compatibility from unit tests
9e31fb3 
As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. This patch removes all remaining checks against C++03 which
were left after NVIDIA#378.

This patch relates to NVIDIA#127 and NVIDIA#378.
@Blonck Blonck mentioned this issue Dec 18, 2023
Merged
1 task
miscco added a commit that referenced this issue Jan 18, 2024
@Blonck @miscco
Remove remaining C++03 compatibility from unit tests (#1228)
5b0762a 
* Remove remaining C++03 compatibility from unit tests

As part of #127, code for unsupported compilation modes/platforms will
be removed. This patch removes all remaining checks against C++03 which
were left after #378.

This patch relates to #127 and #378.

---------

Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
alliepiper added a commit to alliepiper/cccl that referenced this issue Mar 28, 2024
@alliepiper
Merge pull request NVIDIA#127 from robertmaynard/use_public_fmt_in_conda
702ab05 
Propagate fmt requirement in conda envs
@fbusato fbusato mentioned this issue Aug 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request. good first issue Good for newcomers. libcu++ For all items related to libcu++
Projects
CCCL
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miscco