-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cuda-python conda packages should avoid depending on the entire CUDA Toolkit #43
Comments
Would the |
@jakirkham I think building the package requires CUDA headers (so The features depending on |
|
Thanks all! That sounds reasonable. Let's see if @vzhurba01 & @m3vaz have more thoughts 🙂 |
As pointed out, building the package requires CUDA headers. The headers parsed are: Line 37 in 9ac2d31
For building, the headers can be categorized into 3 groups:
(1) Referenced by For runtime, the requirements are:
(2) Many types are built-in though, but not all. One of the ported examples/samples encounter such a scenario. Perhaps (2) can be limited to only the built-in types, and remaining dependency if needed can be added by users? |
I would be happy to keep cudart and nvrtc as “hard” runtime dependencies to ensure the package is fully functional. The main parts I want to strip out are the rest of cuda-toolkit that make it very large, like math libraries. How should we go about making this change? The conda-forge side can simply use this dependency list. We’ll want to reflect the same set of dependencies for the |
Release v12.1.0 trims Conda dependencies to only require NVRTC and CUDART (excluding math libraries). Closing. |
Thanks Vlad! 🙏 |
Conda packages released for
cuda-python
to thenvidia
channel depend oncuda-toolkit
, i.e. the entire CUDA Toolkit.https://anaconda.org/nvidia/cuda-python/files?version=12.0.0
The
cuda-python
package should declare dependencies only on components that are actually used, which might be a more limited subset like these, which I found by readingextern from
declarations:cuda.h
,cuda_runtime.h
,driver_types.h
, and other headers in https://github.com/NVIDIA/cuda-python/blob/main/cuda/ccudart.pxd.innvrtc.h
cuda-python/cuda/cnvrtc.pxd.in
Line 11 in 9ac2d31
cudaProfiler.h
cuda-python/cuda/ccuda.pxd.in
Line 1868 in 9ac2d31
The text was updated successfully, but these errors were encountered: