-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvq++ bridge compilation issue with std::vector<bool>
argument
#1383
Comments
schweitzpgi
added a commit
to schweitzpgi/cuda-quantum
that referenced
this issue
Mar 14, 2024
The operator[] returns a reference, but the AST doesn't have a cast node. So the value appearing in the conditional is not loaded. This adds an explicit check and an error message if the load is returning an unexpected value. Fix NVIDIA#1383.
schweitzpgi
added a commit
that referenced
this issue
Mar 14, 2024
anthony-santana
added a commit
that referenced
this issue
Mar 15, 2024
* Remove exact version specifier in Python install instructions (#1373) Anaconda doesn't have linux-aarch64 packages for Python 3.8.0 and 3.9.0, so without this change, these instructions will fail on ARM. However, when switching to a single "=", conda will allow the user to specify a version up to the number of digits provided, and then use the latest version available after that. For example, if the user provides "3.8", then conda will choose "3.8.18", which is the largest patch version matching "3.8". * Python readme update (#1378) * Fix a bug in sample.h affecting sample_async in library mode (#1379) In library mode, we need to run a tracing pass before actual execution. With multi-qpu, we set_exec_ctx on specific qpu id but didn't reset the context on that particular qpu id (fall back to reset QPU 0 context all the time). * Fix bug - enable list[T] argument specification with kernel builder (#1370) * Enable list[T] specification with kernel builder. Signed-off-by: Alex McCaskey <amccaskey@nvidia.com> * small fixes Signed-off-by: Alex McCaskey <amccaskey@nvidia.com> --------- Signed-off-by: Alex McCaskey <amccaskey@nvidia.com> * * Add docstrings for 'draw' (#1377) * Make nvqc_proxy.py multi-threaded (#1387) Full backstory and test details are in PR. * Fix a few Python notebook examples for release (#1386) * Fix #1348 - synthesis of vectors with small integers. (#1395) The constant array op is using at ArrayAttr, which does not naturally support integral sizes less than i32. This patch upcasts the short values to i32 to get around the issue. Another approach would be to have the constant array op take a DenseArrayAttr, which does support the shorter integral types. Might need a custom parser/pretty printer if we go that route? * [test] Fix deployment issue with #1370 (#1394) * Fix #1383: bridge not lowering to correct IR (#1402) The operator[] returns a reference, but the AST doesn't have a cast node. So the value appearing in the conditional is not loaded. This adds an explicit check and an error message if the load is returning an unexpected value. Fix #1383. * Fix #1392: "syntehsis" of callables (#1398) Refactor the code that was to catch struct value passing (which is not yet implemented) from arguments that are callables. Fix #1392 * Path fix in publishing (#1399) --------- Signed-off-by: Alex McCaskey <amccaskey@nvidia.com> Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com> Co-authored-by: Bettina Heim <heimb@outlook.com> Co-authored-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com> Co-authored-by: Alex McCaskey <amccaskey@nvidia.com> Co-authored-by: Pradnya Khalate <148914294+khalatepradnya@users.noreply.github.com> Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Required prerequisites
Describe the bug
Compilation error:
'cc.if' op operand #0 must be 1-bit signless integer, but got '!cc.ptr<i1>'
when dereferencing astd::vector<bool>
argument in MLIR mode.Steps to reproduce the bug
The above example works in library mode but fails in MLIR mode:
Expected behavior
No compile errors.
Is this a regression? If it is, put the last known working version (or commit) here.
Not a regression
Environment
Suggestions
No response
The text was updated successfully, but these errors were encountered: