Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ood_portal_generator on Ubuntu #541

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Conversation

SpontaneousDuck
Copy link

ood_portal_generator does not properly find the folder to place the generated portal config file. I disabled it on Ubuntu only so the templated file can be used instead.

@dholt
Copy link
Contributor

dholt commented Jun 15, 2020

This should already be the default:

galaxy-roles/ood-ansible/defaults/main.yml:109:ood_portal_generator: false

I'm curious how you ended up with it evaluating to true or why there was a problem with the default setting, I can't replicate the failure

@SpontaneousDuck
Copy link
Author

Ah, so the issue come from me updating ood-ansible. They merged some commits to fix errors with v1.7 so I updated the commit used. The commit changing the default to true was made before the one referenced by this repo (https://github.com/OSC/ood-ansible/blob/5d80a62aa2eb15407366464714c3027591e84246/defaults/main.yml) but was not merged until after. Might need to just track this until the version referenced is updated then? They do say in the PR (OSC/ood-ansible#48) for that that setting it to true will be the default going forward for them so this will need to be set to false for any Ubuntu installs if that repo's reference commit is ever updated.

@dholt dholt merged commit c6803c8 into NVIDIA:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants