Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt changes from JNI for casting from float to decimal #10917

Merged
merged 19 commits into from
Jul 30, 2024

Commits on May 27, 2024

  1. Debugging

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed May 27, 2024
    Configuration menu
    Copy the full SHA
    6076eb1 View commit details
    Browse the repository at this point in the history
  2. Add test

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d406ca2 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Adopt changes from JNI

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d8f7eb7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. WIP

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    00f5ffc View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'branch-24.08' into float_to_decimal

    # Conflicts:
    #	tests/src/test/spark330/scala/org/apache/spark/sql/rapids/utils/RapidsTestSettings.scala
    ttnghia committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9529e47 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    4c02c50 View commit details
    Browse the repository at this point in the history
  2. Enable SparkUT test

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    93422e8 View commit details
    Browse the repository at this point in the history
  3. Reduce test threshold

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1071c0c View commit details
    Browse the repository at this point in the history
  4. Add unit tests

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fb3047c View commit details
    Browse the repository at this point in the history
  5. Cleanup

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2162f5b View commit details
    Browse the repository at this point in the history
  6. Update python tests

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d747cb7 View commit details
    Browse the repository at this point in the history
  7. Update unit tests

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c0083fc View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. cast float to decimal: print number of failures

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c185206 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Change relative error

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    071f433 View commit details
    Browse the repository at this point in the history
  2. Revert "cast float to decimal: print number of failures"

    This reverts commit c185206.
    
    # Conflicts:
    #	tests/src/test/scala/com/nvidia/spark/rapids/CastOpSuite.scala
    ttnghia committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cf6945c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0496699 View commit details
    Browse the repository at this point in the history
  4. Revert "Enable SparkUT test"

    This reverts commit 93422e8.
    ttnghia committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b2c8f21 View commit details
    Browse the repository at this point in the history
  5. Change issue number

    Signed-off-by: Nghia Truong <nghiat@nvidia.com>
    ttnghia committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    239df3c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    a68cbb4 View commit details
    Browse the repository at this point in the history