Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map gen for orc_write_test.py #6566

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Sep 16, 2022

Currently, ORC writer has a bug that could write incompatible nano value if the input timestamp is before 1970 year (#140). This PR changes the timestamp generator in map gen of orc_write_test.py to generate time after 1970.

Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
@ttnghia ttnghia added bug Something isn't working test Only impacts tests P0 Must have for release labels Sep 16, 2022
@ttnghia ttnghia self-assigned this Sep 16, 2022
@ttnghia
Copy link
Collaborator Author

ttnghia commented Sep 16, 2022

build

Copy link
Collaborator

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the known bug in the ORC writer, I'm supportive of changing the test to work around the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Must have for release test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants