Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loss #1

Closed
hcwu1993 opened this issue Nov 8, 2018 · 10 comments
Closed

loss #1

hcwu1993 opened this issue Nov 8, 2018 · 10 comments

Comments

@hcwu1993
Copy link

hcwu1993 commented Nov 8, 2018

i read the code. and the loss function is -logp. why training loss is negative?

@dhgrs
Copy link

dhgrs commented Nov 8, 2018

I had a same question. There is a related discussion. It would help you.
openai/glow#43

@hcwu1993
Copy link
Author

hcwu1993 commented Nov 9, 2018

thank you@dhgrs

@Cheneng
Copy link

Cheneng commented Nov 9, 2018

thank you@dhgrs

Can you explain how to solve the problem?

@rafaelvalle
Copy link
Contributor

rafaelvalle commented Nov 10, 2018

Consider the probability density function of a normal distribution without the normalizing factor \fract{1}{/\sqrt\pi\sigma^2)}, which gives us e^{-\frac{(x - \mu)^2}{2\sigma^2}}.
Now let's take the log of that and substitute \mu with 0 to obtain: -\frac{x^2}{2\sigma^2}.
Using linear algebra notation, that becomes -\frac{x^Tx}{2\sigma^2}.

HTH.

@dhgrs
Copy link

dhgrs commented Nov 10, 2018

@Cheneng
Did you read this comment?
openai/glow#43 (comment)
There is how to convert probability density into probability mass. It would help you.

And I reimplemented WaveGlow with this modification.
https://github.com/dhgrs/chainer-WaveGlow
I got the loss around 6.x at 80k iterations. It is close to WaveNet's one.

@hdmjdp
Copy link

hdmjdp commented Nov 13, 2018

@hcwu1993 what is your loss?

@hcwu1993
Copy link
Author

Uploading image.png…

@deepconsc
Copy link

@dhgrs what's the generation speed on your implementation? And, i guess it works on tacotron2 generated samples, right?

@dhgrs
Copy link

dhgrs commented Apr 3, 2019

@deepconsc I think that your question is not related to this repository or issue. I never mind you open many issues on my repository so please open new issue.

@deepconsc
Copy link

@dhgrs correct, I've opened issue on your repository, and forgot to clean up here. I'm deleting both comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants