Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variableRefreshRate Control #7

Closed
bboudaoud-nv opened this issue Jun 20, 2019 · 2 comments
Closed

variableRefreshRate Control #7

bboudaoud-nv opened this issue Jun 20, 2019 · 2 comments
Assignees
@jspjutNV @joohwankimNV @bboudaoud-nv
Labels
invalid This doesn't seem right question Further information is requested

Comments

@bboudaoud-nv
Copy link
Collaborator

The variableRefreshRate control flag is misleadingly named, and is also hard-coded into App.cpp. We should decide whether to rename/add to an Any config file or remove.
@bboudaoud-nv bboudaoud-nv added invalid This doesn't seem right question Further information is requested labels Jun 20, 2019
@bboudaoud-nv
Copy link
Collaborator Author

I would suggest we use the existing session configuration frameRate parameter to control this as well. If no frameRate is provided in the file (or this is set to 0) we could default to the window refresh rate (though I believe this may be the same as the unlockFramerate case currently, see issue #8).

@bboudaoud-nv bboudaoud-nv mentioned this issue Jun 25, 2019
Closed
@bboudaoud-nv
Copy link
Collaborator Author

bboudaoud-nv commented Jun 25, 2019 •
edited
Loading

This was resolved by removing the variableRefreshRate flag in favor of documenting a frameRate = 0 value in the readme file for experimentconfig.Any. This also closed issue #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jspjutNV jspjutNV

@joohwankimNV joohwankimNV

@bboudaoud-nv bboudaoud-nv

Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jspjutNV @joohwankimNV @bboudaoud-nv