Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello World Example in 5G NR PUSCH Tutorial does not take channel into account. #384

Closed
danielschaeufele opened this issue Apr 4, 2024 · 2 comments

Comments

@danielschaeufele
Copy link

The hello world example in examples/5G_NR_PUSCH.ipynb contains these lines:

x, b = pusch_transmitter(batch_size) # Generate transmit signal and info bits

y = channel([x, no]) # Simulate channel output

b_hat = pusch_receiver([x, no]) # Recover the info bits

The last line should use y instead of x, otherwise the influence of the channel will be ignored.

@SebastianCa
Copy link
Collaborator

SebastianCa commented Apr 4, 2024

Hi @danielschaeufele,
you are right, thank you for reporting this issue. We will fix it with the next release of Sionna.

@naperman
Copy link

naperman commented Apr 8, 2024

When can we expect the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants