Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a bit more docs for SNSPublisher and also added a validity chec… #15

Merged
merged 1 commit into from
Dec 21, 2015

Conversation

durple
Copy link
Contributor

@durple durple commented Dec 21, 2015

Added a bit more docs for SNSPublisher and also added a validity check for the SNS Region in the pubsub package. Also changed the validity checks for an empty string to check against an empty string instead of the length

…k for the SNS Region in the pubsub package. Also changed the validity checks for an empty string to check against an empty string instead of the length.
@jprobinson
Copy link
Contributor

💥 thanks!

jprobinson added a commit that referenced this pull request Dec 21, 2015
Added a bit more docs for SNSPublisher and also added a validity chec…
@jprobinson jprobinson merged commit c309752 into nytimes:master Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants