Remove explicit call to use credentials from environment variables #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidHamza
approved these changes
Jan 24, 2019
fsouza
reviewed
Jan 25, 2019
katrogan
changed the title
jprobinson
reviewed
Jan 25, 2019
pubsub/aws/aws.go
Outdated
| Region: &cfg.Region, | ||
| Endpoint: cfg.EndpointURL, | ||
| } | ||
| if creds != nil { |
There was a problem hiding this comment.
If creds is already nil then setting it into a nil awsConfig.Credentials as nil won't have any effect. With that in mind, I think we can drop this if statement and use the prior, 1 liner for sns.New, right?
There was a problem hiding this comment.
Yeah, I wasn't clear before, but that's what I meant: dropping the else block should be the only change needed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For background, we run our application in a k8s container with an AWS role with SQS & SNS permissions already configured. We've been using a gizmo fork that doesn't configure credentials without trouble for the last few months.