Add resource information to logger of GKE, GCE and AWS EC2 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprobinson
reviewed
Feb 5, 2019
jprobinson
reviewed
Feb 5, 2019
chuhlomin
reviewed
Feb 5, 2019
jprobinson
reviewed
Feb 5, 2019
|
Yeah, lets default to stdout if nothing provided |
jprobinson
reviewed
Feb 5, 2019
| // NewLogger will inspect the environment and, if running in the Google App Engine, | ||
| // Google Kubernetes Engine, Google Compute Engine or AWS EC2 environment, | ||
| // it will return a new Stackdriver logger annotated with the current | ||
| // server's project ID, service ID and version and other environment specific values. |
There was a problem hiding this comment.
Sorry, lil grammar nitpick. Let's replace the first and with a comma.
server's project ID, service ID, version and other environment specific values.
jprobinson
reviewed
Feb 5, 2019
jprobinson
reviewed
Feb 5, 2019
added 2 commits
February 5, 2019 16:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to log to Stackdriver with environment specific information, like instance_id, namespace, etc. for GKE