Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn if not do_scheduler; fix if do_scheduler false; more verbose api error handler; fix update campaign goal #502

Merged
merged 7 commits into from
May 12, 2021
Merged

warn if not do_scheduler; fix if do_scheduler false; more verbose api error handler; fix update campaign goal #502

merged 7 commits into from
May 12, 2021

Conversation

deargle
Copy link
Collaborator

@deargle deargle commented May 12, 2021

overrides flask-api's default handle_error, which would just return a
500 error for any exception

@deargle
use a custom error handler for the api
8ae54e6 
overrides flask-api's default `handle_error`, which would just return a 
500 error for any exception
@deargle
update changelog
b9b9f4b
@coveralls
Copy link

coveralls commented May 12, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 59.8% when pulling 27be242 on api-pass-error-messages into 1188980 on master.

@deargle
fix so that a campaign _task_ gets updated
722b071 
campaign task was not getting updated when the campaign goal was updated
@deargle
start scheduler in paused mode
bf88a42 
so that tasks can be scheduled, modified, or deleted, even when 
scheduler is not _running_ tasks
@deargle
decorator to warn if do_scheduler not true
8b82847
@deargle
update changelog
9a3e0b5
@deargle
typo
27be242
@deargle
Copy link
Collaborator Author

deargle commented May 12, 2021 •
edited
Loading

This PR bloated a bit. All changes:

  • Scheduler is started "paused" if do_scheduler is False, so that tasks can still be
    created, modified, and destroyed
  • Campaigns' "update goal" functionality fixed -- the associated task is updated with
    the new goal
  • /dashboard/campaigns and /dashboard/tasks now flash a warning if do_scheduler is False

@deargle deargle changed the title use a custom error handler for the api warn if not do_scheduler; fix if do_scheduler false; more verbose api error handler; fix update campaign goal May 12, 2021
@deargle deargle merged commit 0a39e53 into master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deargle @coveralls