Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TerminalCommand to Utilize SessionManager for Static Terminal Property #6

Open
5 tasks
p3nGu1nZz opened this issue Mar 25, 2024 · 0 comments
Open
5 tasks
Assignees

Comments

@p3nGu1nZz
Copy link
Collaborator

Overview

The current implementation of the TerminalCommand class uses a static property to reference the terminal instance. This approach can lead to issues with flexibility and testability. To improve the design, we propose refactoring the TerminalCommand class to use the SessionManager for managing terminal instances.

Goals

  • Decouple the TerminalCommand class from a static terminal instance.
  • Implement the SessionManager to handle terminal sessions.
  • Enhance the maintainability and testability of the terminal management system.

Tasks

  • Create a new SessionManager class that will manage terminal instances.
  • Replace the static terminal property in the TerminalCommand class with a method to retrieve the current terminal session from the SessionManager.
  • Update all references to the static terminal property throughout the codebase.
  • Ensure that existing functionality is preserved and that all unit tests pass.
  • Document the changes and update any relevant documentation.

Acceptance Criteria

  • The TerminalCommand class no longer uses a static property for the terminal instance.
  • The SessionManager is fully implemented and integrated with the TerminalCommand class.
  • All existing tests pass, and new tests are added to cover the changes.
  • The system behaves as expected, with no regressions in functionality.

Please review the proposed changes and provide feedback or approval to proceed with the implementation.

@p3nGu1nZz p3nGu1nZz self-assigned this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant