Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jobs): [nan-1010] use void #2195

Conversation

khaliqgant
Copy link
Member

@khaliqgant khaliqgant commented May 23, 2024

Describe your changes

As explained by Thomas:
image

Use void since we're not explicitly handling the promise resolution of the webhook sending

Tested this against returning a 504 (what the customer is returning from their webhook) from a webhook with Temporal and the task execution completes even as the webhook continues to retry. With async usage, the temporal activity is still in running state while the webhook retries.

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

Copy link

linear bot commented May 23, 2024

@khaliqgant khaliqgant changed the title fix(jobs): [nan-1010] reduce retries fix(jobs): [nan-1010] use void May 23, 2024
Copy link
Collaborator

@TBonnin TBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also maybe lower the retry attempts to 7 or 8 instead of 10. The 10th retry almost wait for a minute

@khaliqgant khaliqgant merged commit a1c5d3a into master May 23, 2024
20 checks passed
@khaliqgant khaliqgant deleted the khaliq/nan-1010-descrepency-between-sync-status-in-connections-vs-activity branch May 23, 2024 17:24
@khaliqgant
Copy link
Member Author

I would also maybe lower the retry attempts to 7 or 8 instead of 10. The 10th retry almost wait for a minute

Dropped to 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants