Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
As explained by Thomas:
![image](https://private-user-images.githubusercontent.com/1724137/333107968-49464765-394f-4bdc-8c15-388f72704980.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMjQ2MDYsIm5iZiI6MTcyNjEyNDMwNiwicGF0aCI6Ii8xNzI0MTM3LzMzMzEwNzk2OC00OTQ2NDc2NS0zOTRmLTRiZGMtOGMxNS0zODhmNzI3MDQ5ODAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTJUMDY1ODI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2I2MDA3MGJiOTcxNWIxYWQxM2FmOTkyNDVmOWRkZWM5ZDlmMGNiMzgxY2E1MDAwMzA1MzE3ZjU4Y2UxNTQ5OCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.MgUgiGDXFC7-F1O8ru_gYQnWXQ5Y_NMU6bNreB5V8XI)
Use void since we're not explicitly handling the promise resolution of the webhook sending
Tested this against returning a 504 (what the customer is returning from their webhook) from a webhook with Temporal and the task execution completes even as the webhook continues to retry. With
async
usage, the temporal activity is still in running state while the webhook retries.Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)