Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jobs): [nan-1010] use void #2195

Merged
merged 3 commits into from
May 23, 2024
Merged

fix(jobs): [nan-1010] use void #2195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ba6fe2
[nan-1010] reduce retries
khaliqgant May 23, 2024
bef1dd1
[nan-1010] void instead of await for webhook update
khaliqgant May 23, 2024
e068310
[nan-1010] bring retries down
khaliqgant May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/shared/lib/services/notification/webhook.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { stringifyError } from '@nangohq/utils';

dayjs.extend(utc);

const RETRY_ATTEMPTS = 10;
const RETRY_ATTEMPTS = 7;

const NON_FORWARDABLE_HEADERS = [
'host',
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/lib/services/sync/run.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ export default class SyncRun {
deleted
};

await webhookService.sendSyncUpdate(
void webhookService.sendSyncUpdate(
this.nangoConnection,
this.syncName,
model,
Expand Down
Loading