Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax SQLModel deps version to >=0.0.8,<0.1.0 #383

Closed
cristiangreco94 opened this issue Apr 30, 2024 · 2 comments
Closed

Relax SQLModel deps version to >=0.0.8,<0.1.0 #383

cristiangreco94 opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@cristiangreco94
Copy link

cristiangreco94 commented Apr 30, 2024

Motivation: describe the problem to be solved
Current SQLModel version is set to ^0.0.8. This translates to >=0.0.8 <0.0.9-0 due to the Caret special treatment of 0s.
SQLModel 0.0.8 constraints SQLAlchemy to be <2, making NannyML not compatible with projects using newer versions of SQLAlchamy.

Describe the solution you'd like
I would change SQLModel versioning to be at the very least >=0.0.8,<0.1.0. Current version of SQLModel is 0.0.18 and it fully supports SQLAlchemy above or below 2.x.y, so not a problem for backcompatibility. I also tested it locally and no NannyML unit-test was broken by upgrating SQLModel to 0.0.18.

@cristiangreco94 cristiangreco94 added the enhancement New feature or request label Apr 30, 2024
@cristiangreco94 cristiangreco94 changed the title Relax SQLModel deps version to >=0.0.8 Relax SQLModel deps version to >=0.0.8,<0.1.0 May 2, 2024
@nnansters
Copy link
Contributor

Yup, sorry for being late with the dependency bumps on this one. Your suggestion was indeed totally valid, thanks for double checking.

I've updated the dependency in #401 , feel free to check and make any remarks you might have!

Copy link

stale bot commented Aug 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants