Unique identifier column to nannyML datasets #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 100 100
Lines 7554 7554
Branches 1351 1351
=======================================
Hits 6274 6274
Misses 956 956
Partials 324 324 ☔ View full report in Codecov by Sentry. |
nnansters
approved these changes
Jan 18, 2024
|
Oh thanks for fixing the broken tests @nnansters 💜 |
nnansters
added a commit
that referenced
this pull request
Jan 22, 2024
* add unique ID column * Remove duplicate 'identifier' column * Fix broken tests * isort changes --------- Co-authored-by: Niels Nuyttens <niels@nannyml.com>
nnansters
added a commit
that referenced
this pull request
Jan 22, 2024
* First version of continuous distribution calculator working * Refactor plotting to support drift results for alert specification * Support running ContinuousDistributionCalculator in the Runner * Fix pickling ContinuousDistributionCalculator * Working version of CategoricalDistributionCalculator * This is not how overload works. * Getting index-based plots to work * Support categorical distribution calculator in the runner * Fix Flake8 & mypy * Expose option to downscale resolution of individual joyplots for continuous distribution plots * Expose cumulative density for KDE quartiles * Use first point >= quartile instead of closest * Updated default thresholds for Univariate Drift detection methods * Fix broken ranker tests. This is why we do PR's kids. * Fix linting * Register summary stats in CLI runner (#353) * Unique identifier column to nannyML datasets (#348) * add unique ID column * Remove duplicate 'identifier' column * Fix broken tests * isort changes --------- Co-authored-by: Niels Nuyttens <niels@nannyml.com> --------- Co-authored-by: Michael Van de Steene <michael@nannyml.com> Co-authored-by: Michael Van de Steene <124588413+michael-nml@users.noreply.github.com> Co-authored-by: Santiago Víquez <santi.viquez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an identifier column to every dataset that is part of nannyML OSS so they can easily be used in the cloud product when running examples/tutorials.