Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: distribution calculators #352

Merged
merged 19 commits into from
Jan 22, 2024
Merged

Conversation

nnansters
Copy link
Contributor

Two new calculators to calculate and plot the distributions of continuous and categorical features.

These mimic the functionality of the UnivariateDriftCalculator, but without the need to store the entire reference dataset.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 294 lines in your changes are missing coverage. Please review.

Comparison is base (7b5b969) 83.05% compared to head (581277d) 80.23%.

Files Patch % Lines
nannyml/distribution/categorical/result.py 28.87% 101 Missing ⚠️
nannyml/distribution/continuous/calculator.py 21.15% 82 Missing ⚠️
nannyml/distribution/continuous/result.py 24.13% 66 Missing ⚠️
nannyml/distribution/categorical/calculator.py 22.41% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   83.05%   80.23%   -2.83%     
==========================================
  Files         100      107       +7     
  Lines        7554     7953     +399     
  Branches     1351     1451     +100     
==========================================
+ Hits         6274     6381     +107     
- Misses        956     1249     +293     
+ Partials      324      323       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters marked this pull request as ready for review January 22, 2024 12:01
@nnansters nnansters requested a review from nikml as a code owner January 22, 2024 12:01
@nnansters nnansters merged commit 2af5e7b into main Jan 22, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants