Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1D, 2D, 3D viewing #9

Closed
royerloic opened this issue Oct 14, 2018 · 1 comment
Closed

1D, 2D, 3D viewing #9

royerloic opened this issue Oct 14, 2018 · 1 comment
Labels
feature New feature or request
Milestone
0.2

Comments

@royerloic
Copy link
Member

The viewer should supports 3 modes:
1D: Using vispy plotting integrated in the scene graph
2D: current code
3D: Vispy volume renderer

The number of sliders is automatically adapted,
other types of objects (lines, points, etc..) should also be displayed
by simple projection in a straightforward manner.
@royerloic royerloic added the feature New feature or request label Oct 14, 2018
@sofroniewn sofroniewn added this to the 0.2.0 milestone May 11, 2019
@sofroniewn sofroniewn mentioned this issue Sep 7, 2019
Open
@sofroniewn
Copy link
Contributor

We've made good progress towards 3D rendering recently including #493 where we have merged support for 3D rendering with many of our layer types.

We haven't begun to address 1D rendering yet, but that could be a useful feature so I've made a new issue #516 to explicitly discuss 1D rendering and am closing this one.

ttung pushed a commit to ttung/napari that referenced this issue Dec 20, 2019
Modify visibility changed slot to only update title if the object is …
5c5b744 
…visible

The visibilitychanged slot currently updates the title regardless of the visibility. We are seeing a crash when the viewer is shut down and a signal is sent to the visibilitychanged slot.  That executes some code which causes a segfault in the python process[1].  This PR changes the visibility changed slot to only update the title bar if the widget is visible.

[1]
```
  * frame #0: 0x0000000115cc96e4 QtWidgets`QWidgetPrivate::reparentFocusWidgets(QWidget*) + 356
    frame napari#1: 0x0000000115cb99cf QtWidgets`QWidget::setParent(QWidget*, QFlags<Qt::WindowType>) + 911
    frame napari#2: 0x0000000115cb82c0 QtWidgets`QWidgetPrivate::init(QWidget*, QFlags<Qt::WindowType>) + 688
    frame napari#3: 0x0000000115d73e5e QtWidgets`QFrame::QFrame(QFramePrivate&, QWidget*, QFlags<Qt::WindowType>) + 14
    frame napari#4: 0x0000000115dc3705 QtWidgets`QLabel::QLabel(QWidget*, QFlags<Qt::WindowType>) + 277
    frame napari#5: 0x0000000116503189 QtWidgets.abi3.so`Sbk_QLabel_Init(_object*, _object*, _object*) + 1497
    frame napari#6: 0x000000010015f84d Python`wrap_init + 12
    frame napari#7: 0x0000000100113e64 Python`_PyObject_FastCallDict + 143
    frame napari#8: 0x00000001001b17a2 Python`call_function + 439
    frame napari#9: 0x00000001001aa46b Python`_PyEval_EvalFrameDefault + 3078
    frame napari#10: 0x00000001001b1ee2 Python`_PyEval_EvalCodeWithName + 1638
    frame napari#11: 0x00000001001b281b Python`_PyFunction_FastCallDict + 447
    frame napari#12: 0x0000000100113e99 Python`_PyObject_FastCallDict + 196
    frame napari#13: 0x0000000100113fa3 Python`_PyObject_Call_Prepend + 131
    frame napari#14: 0x0000000100113d1e Python`PyObject_Call + 101
    frame napari#15: 0x000000010015f7d1 Python`slot_tp_init + 57
    frame napari#16: 0x000000010015c782 Python`type_call + 178
    frame napari#17: 0x0000000100113e64 Python`_PyObject_FastCallDict + 143
    frame napari#18: 0x00000001001141fa Python`_PyObject_FastCallKeywords + 97
    frame napari#19: 0x00000001001b17a2 Python`call_function + 439
    frame napari#20: 0x00000001001aa4fb Python`_PyEval_EvalFrameDefault + 3222
    frame napari#21: 0x00000001001b28e0 Python`_PyFunction_FastCall + 110
    frame napari#22: 0x0000000100113e99 Python`_PyObject_FastCallDict + 196
    frame napari#23: 0x0000000100113fa3 Python`_PyObject_Call_Prepend + 131
    frame napari#24: 0x0000000100113d1e Python`PyObject_Call + 101
    frame napari#25: 0x000000011126f146 libpyside2.abi3.5.14.dylib`PySide::SignalManager::callPythonMetaMethod(QMetaMethod const&, void**, _object*, bool) + 534
    frame napari#26: 0x000000011126eb77 libpyside2.abi3.5.14.dylib`PySide::SignalManager::qt_metacall(QObject*, QMetaObject::Call, int, void**) + 519
```
melonora added a commit to melonora/napari that referenced this issue May 8, 2023
@melonora
Merge pull request napari#9 from melonora/polygon_lasso
2079e0a 
Fix respecting distance threshold
Tiny refactor
Czaki pushed a commit that referenced this issue Jun 23, 2023
@lucyleeow @Czaki
Use imshow in getting_started (#9)
2f414b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@royerloic @sofroniewn