Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directive: no support for formControl #40

Open
SuperITMan opened this issue Dec 14, 2021 · 0 comments
Open

directive: no support for formControl #40

SuperITMan opened this issue Dec 14, 2021 · 0 comments
Labels
comp: directive enhancement New feature or request
Milestone

Comments

@SuperITMan
Copy link
Member

🚀 Feature request

Current behavior

[ngxFormErrors] directive expects to receive a formControlName. Based on this form control name, it gets the FormControl from the FormGroupDirective (parent ForrmGroup).

The directive cannot receive a FormControl instead of a control name.

Expected behavior

Give the ability to pass a FormControl or a FormControlName depending on the case.

What is the motivation / use case for changing the behavior?

Improving the library.

@SuperITMan SuperITMan added enhancement New feature or request comp: directive labels Dec 14, 2021
@SuperITMan SuperITMan added this to the 1.1.0 milestone Dec 14, 2021
@SuperITMan SuperITMan modified the milestones: 1.1.0, 1.2.0 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: directive enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant