Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix workflow bump angular deps #2957

Conversation

SuperITMan
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

"dependabot-sync-stark-dependencies" workflow doesn't work due to logs issues.

"bump-angular-deps" workflow does not work because it uses GITHUB_TOKEN instead of NBBBOT_TOKEN. When using GITHUB_TOKEN to create a Pull Request, GitHub Actions does not trigger any workflow.

What is the new behavior?

Fixed logs in both workflows + Add support to update @angular/* dependencies versions of the showcase and the starter.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

…case and starter

Replace secret `GITHUB_TOKEN` by `NBBBOT_TOKEN` when creating a Pull Request
to trigger build workflow related to the new PR.

Add support to update `angular/*` dependencies in showcase and starter.
…S_DIR` and `LOGS_FILE`

Create logs folder + add cache support for npm dependencies
@SuperITMan SuperITMan added type: bug type: feature dependencies Pull requests that update a dependency file comp: ci & tooling CI, GitHub Actions, ... labels Sep 2, 2021
@SuperITMan SuperITMan added this to the 12.0.0-rc.0 milestone Sep 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.202% when pulling 1304e47 on SuperITMan:bugfix/fix-workflow-bump-angular-deps into a3a7049 on NationalBankBelgium:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci & tooling CI, GitHub Actions, ... dependencies Pull requests that update a dependency file type: bug type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants