Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-ui): fix issue with table on action #3400

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

mhenkens
Copy link
Contributor

When changing language we got an issue with the name of the column for the Actions in NL

ISSUES CLOSED: #3391

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 3391

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.208% when pulling bb5682c on mhenkens:bugfix/3391-master into c728128 on NationalBankBelgium:master.

When changing language we got an issue with the name of the column for the Actions in NL
The column definition name was translated bt shouldn't because it used
to get the action in the row object via the 'Actions' property

ISSUES CLOSED: NationalBankBelgium#3391
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SuperITMan
Copy link
Member

LGTM 👍

@SuperITMan SuperITMan merged commit 6734bcd into NationalBankBelgium:master Jul 5, 2022
@mhenkens mhenkens deleted the bugfix/3391-master branch July 27, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables Action issue when changing language
3 participants