Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in image label in tutorials #70

Closed
dap6000 opened this issue Feb 28, 2022 · 2 comments · Fixed by #72
Closed

Typo in image label in tutorials #70

dap6000 opened this issue Feb 28, 2022 · 2 comments · Fixed by #72

Comments

@dap6000
Copy link

dap6000 commented Feb 28, 2022

See this image -> https://docs.nativescript.org/assets/images/tutorial/tutorial-example-app-details-breakdown.png

Has a label that says "Here Image" while the tutorial text refers to it as the "Hero Image". The assets/images/tutorial/ directory doesn't seem to exist here in the repo. I'm not sure what it would take to replace the image in production.
@rigor789
Copy link
Member

It's here: https://github.com/NativeScript/docs-new/blob/44075a4beb95c789f4b710fd441efd9f7dc4845e/public/assets/images/tutorial/tutorial-example-app-details-breakdown.png

@williamjuan027 you might have the source file to fix it? Here Image -> Hero Image

@williamjuan027 williamjuan027 mentioned this issue Mar 2, 2022
Merged
@williamjuan027
Copy link
Member

@rigor789 I've uploaded an updated image in #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix tutorial image typo williamjuan027/docs-new
3 participants
@dap6000 @rigor789 @williamjuan027