Fix screenshot taking and screen recording in AR #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screenshot taking wasn't working due to a react "this" issue. In JavaScript,
class methods are not bound to the instance like an arrow function is.
So, when a user of ViroARSceneNavigator tries to use these functions,
the "this" instance didn't have all of the React properties that make
React Native's findNodeHandle work correctly.
Changing functions like:
async _takeScreenshot(fileName, saveToCameraRoll) {
// ...
}
To
_takeScreenshot = (filename, saveToCameraRoll) => {
// ...
}
Fixes the issue.
Also adds more documentation to the ViroARSceneNavigator.
|
TODO:
|
This was
linked to
issues
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot taking wasn't working due to a react "this" issue. In JavaScript, class methods are not bound to the instance like an arrow function is. So, when a user of ViroARSceneNavigator tries to use these functions, the "this" instance didn't have all of the React properties that make React Native's findNodeHandle work correctly.
Changing functions like:
To
Fixes the issue and allows "this" to be properly accessed by
findNodeHandle()Also adds more documentation to the ViroARSceneNavigator.