-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update android #261
chore: Update android #261
Conversation
Android build was wildly out of date. This is the culmination of a few days of battling gradle version issues, kotlin version issues, and java version issues. In this commit, viro react compiles with each of the dependencies (renderer, etc.) and creates the bridge properly both in a React Native project and an Expo project. There's a "hack" in the Expo withViroAndroid.ts file. Expo generates a MainApplication.kt file that doesn't actually add the ViroReact packages to the application. Todo: - Continue fixing arrow functions in some class components - Rebuild virocore and debug crash in VROMathInvertMatrix - Deploy release - Add code to show a view instead of initializing AR if the device doesn't support AR Core
@robertjcolley Kotlin plugins need to be v1.8.x or higher v1.6.x is leading to issues. I'm getting similar issues while building my app. Here are the changes I did: android/build.gradle
android/viro_bridge/build.gradle
FYI: I've got these changes in my branch, will open a PR once I'm done testing it out. |
@robertjcolley
My changes should also fix some of these errors. |
require('expo') in a react native project caused this issue, but for some reason the error message was about VIRO_VERSION, which was working correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updates!
But I have a question about console.log
.
It takes huge number of lines in my terminal and it occurs overflow too.
Is these things are necessary?
|
||
console.log("[ViroScene].render"); | ||
console.log("[ViroScene].render", this); | ||
console.log("[ViroScene].render", this.props); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertjcolley is these console.log
are necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! I'll remove them in the next release I'm doing this week. Sorry about that! There are a few other places I think I put them.
removes console.log statements debugging a previous issue that were left in during #261.
Android build was wildly out of date. This is the culmination of a few days of battling gradle version issues, kotlin version issues, and java version issues. In this commit, viro react compiles with each of the dependencies (renderer, etc.) and creates the bridge properly both in a React Native project and an Expo project.
There's a "hack" in the Expo withViroAndroid.ts file. Expo generates a MainApplication.kt file that doesn't actually add the ViroReact packages to the application.
Todo:
Should I use a library likeDeferring to later datereact-native-builder-bob
to re-scaffold the library?