-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation: Address book #503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keerifox
reviewed
Nov 28, 2021
keerifox
reviewed
Nov 28, 2021
"successfully-deleted-address-book-entry": "Successfully deleted address book entry", | ||
"the-balance-will-be-displayed-in-the-address-book": "The balance will be displayed in the address book.", | ||
"this-name-is-already-in-use-please-use-a-unique-name": "This name is already in use! Please use a unique name", | ||
"this-name-is-reserved-for-wallet-accounts-without-a-label": "This name is reserved for wallet accounts without a label", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be reused here
return this.notifications.sendError(`This name is reserved for wallet accounts without a label`); |
keerifox
reviewed
Nov 28, 2021
"show-total-tracked-balance": "Show Total Tracked Balance", | ||
"successfully-deleted-address-book-entry": "Successfully deleted address book entry", | ||
"the-balance-will-be-displayed-in-the-address-book": "The balance will be displayed in the address book.", | ||
"this-name-is-already-in-use-please-use-a-unique-name": "This name is already in use! Please use a unique name", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be reused here
return this.notifications.sendError(`This name is already in use! Please use a unique name`); |
(there are 3 more strings in account details like that, which could use translation from the address book) |
vedelaar
pushed a commit
to vedelaar/Biome
that referenced
this pull request
Aug 2, 2022
* translation address book * fix lint * 2-link
vedelaar
pushed a commit
to vedelaar/Biome
that referenced
this pull request
Aug 2, 2022
* translation address book * fix lint * 2-link
Zosoled
added a commit
to Zosoled/Nault
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.