Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Address book #503

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Translation: Address book #503

merged 3 commits into from
Nov 29, 2021

Conversation

BitDesert
Copy link
Member

No description provided.

src/assets/i18n/en.json Outdated Show resolved Hide resolved
"successfully-deleted-address-book-entry": "Successfully deleted address book entry",
"the-balance-will-be-displayed-in-the-address-book": "The balance will be displayed in the address book.",
"this-name-is-already-in-use-please-use-a-unique-name": "This name is already in use! Please use a unique name",
"this-name-is-reserved-for-wallet-accounts-without-a-label": "This name is reserved for wallet accounts without a label",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be reused here

return this.notifications.sendError(`This name is reserved for wallet accounts without a label`);

"show-total-tracked-balance": "Show Total Tracked Balance",
"successfully-deleted-address-book-entry": "Successfully deleted address book entry",
"the-balance-will-be-displayed-in-the-address-book": "The balance will be displayed in the address book.",
"this-name-is-already-in-use-please-use-a-unique-name": "This name is already in use! Please use a unique name",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be reused here

return this.notifications.sendError(`This name is already in use! Please use a unique name`);

@keerifox
Copy link
Member

(there are 3 more strings in account details like that, which could use translation from the address book)

@BitDesert BitDesert added the translation Translations label Nov 29, 2021
@BitDesert BitDesert merged commit e35353c into master Nov 29, 2021
@BitDesert BitDesert deleted the translation_address-book branch November 29, 2021 20:06
vedelaar pushed a commit to vedelaar/Biome that referenced this pull request Aug 2, 2022
* translation address book

* fix lint

* 2-link
vedelaar pushed a commit to vedelaar/Biome that referenced this pull request Aug 2, 2022
* translation address book

* fix lint

* 2-link
Zosoled added a commit to Zosoled/Nault that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants