Agent Crashes When Executed Command Returns an Error

[Ne0nd0g]

Prerequisite

• I have searched the opened & closed issues
• I have searched the WIKI and its FAQ page

Environment Data

• Merlin Version: v1.4.2
• Merlin Build: 5ac7f6e
• Go Version: 1.17
• GOPATH Environment Variable: N/A
• GOROOT Environment Variable: N/A
• Operating System: Windows

Expected Behavior

Expected to create a sacrificial logon session and then run a command without the agent crashing.

Actual Behavior

Agent crashes after creating a sacrificial logon session and then trying to run a command

Steps to Reproduce Behavior

1. From a Windows agent, create a sacrificial logon sessions with token make ACME\\RAstley password
2. Run a program with that token by issuing run klist
3. Agent will crash

Misc Information

The problem is in the commands/exec_windows.go file because error checks are not performed before trying to reference the object:

	cmd := exec.Command(application, args...)
	cmd.SysProcAttr = attr

	out, err := cmd.CombinedOutput()
	stdout = fmt.Sprintf("Created %s process with an ID of %d\n", application, cmd.Process.Pid)