Added CustomerServiceContactDetails and updates Vehicle/VehicleRef #584

ue71603 · 2023-12-12T16:51:57Z

fixes #401

@Aurige Where would I put vehicles in the GeneralFrame? I think I can't add vehicles or Fleet there? Or did I miss something?

@codeape2

and I think a Type and a Vehicle might be possible. Added example from @codeape2

Aurige · 2023-12-12T17:55:12Z

@Aurige Where would I put vehicles in the GeneralFrame? I think I can't add vehicles or Fleet there? Or did I miss something?

There is a MobilityServiceFrameGroup with all you need but it is in a MobilityServiceFrame !!

skinkie · 2023-12-12T17:56:59Z

@Aurige Where would I put vehicles in the GeneralFrame? I think I can't add vehicles or Fleet there? Or did I miss something?

There is a MobilityServiceFrameGroup with all you need but it is in a MobilityServiceFrame !!

So that should be added to the GeneralFrame?

Aurige · 2023-12-12T18:25:21Z

The GeneralFrame includes any DatamanagedObject, so that's automatic for all first class objects

skinkie

I like!

But question, shouldn't vehicleRef / VehicleTypeRef be a choice?

ue71603 · 2023-12-12T19:02:13Z

I pondered it. But then thought you may have both. But I think we can briefly discuss this with @Aurige

skinkie · 2023-12-12T19:10:34Z

I pondered it. But then thought you may have both. But I think we can briefly discuss this with @Aurige

In my perspective a Vehicle is part of a VehicleType, and the VehicleType may not conflict with a Vehicle.

nick-knowles · 2024-04-15T22:35:14Z

A VEHICLE is an instance of a VEHICLE TYPE, not part of it
A VEHICLE may be part of a FLEET.

VEHICLES and FLEETs may be declared in a RESOURCE FRAME (we should probbaly have a separate frame for all vehicle related stuff likr vehicles, vehilce types and deck plans - future)

nick-knowles · 2024-04-15T22:41:04Z

COntact details have been added to VEHICLE in Netex and Transmodel UML models

nick-knowles · 2024-04-16T06:42:37Z

Transmodel also updated

was there during EPIAP.

<xsd:element ref="VehicleModelProfileRef" minOccurs="0"/>

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

trurlurl · 2024-05-22T08:56:03Z

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

 				<xsd:annotation>
-					<xsd:documentation>Energy required for a full charge. +v2.0</xsd:documentation>
+					<xsd:documentation>Private code of the vehicle.</xsd:documentation>
 				</xsd:annotation>
 			</xsd:element>
 			<xsd:sequence>
 				<xsd:element name="equipmentProfiles" type="vehicleEquipmentProfileRefs_RelStructure" minOccurs="0">


Isn't that perhaps superfluous? We already have the equipment profiles for the model by equipmentProfiles in the VehicleModelGroup (and for the specific vehicle we have actualVehicleEquipments).

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

xsd/netex_framework/netex_reusableComponents/netex_vehicle_version.xsd

…_version.xsd Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>

nick-knowles · 2024-06-04T11:55:29Z

VEHICLE MODEL PROFILE mssing from Transmodel RESOURCE FRAME diagram a- added

ALready shown in NeTEx model

I don't really like breaking example (unless they were obviously wrong) The VehicleCodeGroup is only used once (in VehicleGroup): so I would remove the equipmentProfiles and VehicleModelProfileRef from it and move them to this line 182 (in fact just remove them from VehicleCodeGroup and add equipmentProfiles before VehicleModelProfileRef of line 182 ... removed tmp0000. checked examples

…ultiple Contact

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

…_version.xsd

Aurige · 2024-06-07T15:34:07Z

examples/functions/newModes/NewModes-CarClubExample.xml

@@ -374,6 +379,7 @@
 							<members>
 								<Vehicle version="any" id="car_01">
 									<OperatorRef version="any" ref="coc:MCR"/>
+									<ContactRef ref="contact1" version="any"/>
 									<SimpleVehicleTypeRef version="any" ref="small_car"/>
 									<VehicleModelRef version="any" ref="mini_whiz"/>
 									<CarModelProfileRef version="any" ref="model_a"/>


I'm puzzled because this still does not validated (error on CarModelProfileRef ) as if the VehicleCodeGroup has changed position... but it does not seem to be the case !

@Aurige What is not validating?

NeTEx\examples\functions\newModes\NewModes-CarClubExample.xml (and it validates in master, so we broke something at some point)

@Aurige to provide the details of the error

@Aurige for me it validates in the branch..

The changes coming from this code are here. It is only Contact and ContactRef. However, we might have changed it before.

I'm not sure what is going on, but when I checkout that brach and validate the CarClub example, I get this (I just double checked)

Same pb with XMLLint

ue71603 · 2024-07-08T08:28:45Z

@Aurige Sorry, I can't do nothing. It is valid on my end. I think you must find the error on your side.

Aurige · 2024-07-10T09:59:44Z

Ok, I found the issue (a weird network error between Github Desktop and Github site ... with no error at check out, until you re-ask for Fetch). Sorry for bothering !

Added CustomerServiceContactDetails

7f76c93

ue71603 added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated needs transmodel update labels Dec 12, 2023

ue71603 requested review from skinkie, Aurige, JohanEntur and trurlurl December 12, 2023 16:51

ue71603 mentioned this pull request Dec 12, 2023

CustomerServiceContactDetails on Vehicle #401

Closed

JohanEntur approved these changes Dec 12, 2023

View reviewed changes

ue71603 and others added 2 commits December 12, 2023 18:11

added VehicleRef to ServiceJourney

7b69a31

and I think a Type and a Vehicle might be possible. Added example from @codeape2

Lint and update documentation tables

ce54bd5

ue71603 mentioned this pull request Dec 12, 2023

Assigned vehicle for ServiceJourney #345

Closed

ue71603 changed the title ~~Added CustomerServiceContactDetails~~ Added CustomerServiceContactDetails and updates Vehicle/VehicleRef Dec 12, 2023

ue71603 mentioned this pull request Dec 12, 2023

VehicleRef on ServiceJourney #400

Closed

skinkie reviewed Dec 12, 2023

View reviewed changes

ue71603 added the group_decision_needed label Dec 12, 2023

trurlurl approved these changes Dec 12, 2023

View reviewed changes

ue71603 assigned ue71603 and nick-knowles and unassigned ue71603 Dec 14, 2023

ue71603 removed the group_decision_needed label Dec 14, 2023

ue71603 added 2 commits May 10, 2024 19:21

typos and equipmentProfiles added to VehicleModel

93a596a

was there during EPIAP.

also VehicleModelProfileRef to VehicleModel

af51d62

<xsd:element ref="VehicleModelProfileRef" minOccurs="0"/>

trurlurl requested changes May 22, 2024

View reviewed changes

Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType…

e190c35

…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

Aurige reviewed May 22, 2024

View reviewed changes

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Outdated Show resolved Hide resolved

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Outdated Show resolved Hide resolved

Aurige requested changes May 23, 2024

View reviewed changes

xsd/netex_framework/netex_reusableComponents/netex_vehicle_version.xsd Show resolved Hide resolved

ue71603 and others added 2 commits May 23, 2024 09:26

Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType…

c327e7a

…_version.xsd Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>

Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType…

8afc953

…_version.xsd Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>

ue71603 and others added 3 commits June 5, 2024 14:18

modeled the Contacts correct and corrected that contacts must allow m…

7a7e971

…ultiple Contact

Lint and update documentation tables

ae93675

ue71603 removed their assignment Jun 5, 2024

ue71603 requested review from Aurige, skinkie, JohanEntur and trurlurl June 5, 2024 12:53

trurlurl reviewed Jun 5, 2024

View reviewed changes

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Outdated Show resolved Hide resolved

Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType…

2f2d932

…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

trurlurl approved these changes Jun 5, 2024

View reviewed changes

ue71603 commented Jun 5, 2024

View reviewed changes

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Outdated Show resolved Hide resolved

ue71603 and others added 2 commits June 5, 2024 17:37

Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType…

1d7a9a0

…_version.xsd

Lint and update documentation tables

168b6fd

Aurige reviewed Jun 7, 2024

View reviewed changes

Aurige approved these changes Jul 10, 2024

View reviewed changes

skinkie assigned ue71603 Jul 25, 2024

Merge branch 'next' into Customer-Information-On-Vehicle

c665677

Aurige merged commit 3465eec into next Jul 25, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added CustomerServiceContactDetails and updates Vehicle/VehicleRef #584

Added CustomerServiceContactDetails and updates Vehicle/VehicleRef #584

ue71603 commented Dec 12, 2023

Aurige commented Dec 12, 2023

skinkie commented Dec 12, 2023

Aurige commented Dec 12, 2023

skinkie left a comment

ue71603 commented Dec 12, 2023

skinkie commented Dec 12, 2023

nick-knowles commented Apr 15, 2024

nick-knowles commented Apr 15, 2024 •

edited

Loading

nick-knowles commented Apr 16, 2024

trurlurl May 22, 2024

nick-knowles commented Jun 4, 2024

Aurige Jun 7, 2024

ue71603 Jun 22, 2024

Aurige Jun 24, 2024

Aurige Jun 26, 2024

ue71603 Jun 27, 2024

ue71603 Jun 27, 2024

Aurige Jul 5, 2024

Aurige Jul 5, 2024

ue71603 commented Jul 8, 2024

Aurige commented Jul 10, 2024

Added CustomerServiceContactDetails and updates Vehicle/VehicleRef #584

Added CustomerServiceContactDetails and updates Vehicle/VehicleRef #584

Conversation

ue71603 commented Dec 12, 2023

Aurige commented Dec 12, 2023

skinkie commented Dec 12, 2023

Aurige commented Dec 12, 2023

skinkie left a comment

Choose a reason for hiding this comment

ue71603 commented Dec 12, 2023

skinkie commented Dec 12, 2023

nick-knowles commented Apr 15, 2024

nick-knowles commented Apr 15, 2024 • edited Loading

nick-knowles commented Apr 16, 2024

Choose a reason for hiding this comment

nick-knowles commented Jun 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ue71603 commented Jul 8, 2024

Aurige commented Jul 10, 2024

nick-knowles commented Apr 15, 2024 •

edited

Loading