Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite service to use Flask #60

Closed
vpetersson opened this issue Jun 16, 2021 · 3 comments
Closed

Rewrite service to use Flask #60

vpetersson opened this issue Jun 16, 2021 · 3 comments
Assignees
Labels
tech debt Testing, refactoring, etc
Milestone

Comments

@vpetersson
Copy link
Contributor

Let's rewrite the diagnostics page to use Flask, which gives us a lot of free features out of the box. We should then serve this app using Gunicorn.

To keep things simple, let's ditch the Nginx container for the time being and serve Gunicorn on port 8000 with Docker exposing it on port 80. That way we don't need to run the container as root.

This is a per-requisite for #39.

@vpetersson vpetersson added this to the Production milestone Jun 16, 2021
This was referenced Jun 16, 2021
@ryanteck
Copy link
Contributor

@vpetersson Primarily the reason the container is run as root is to access many of the hardware and networking services. Not for Nginx.

@robputt
Copy link
Contributor

robputt commented Jun 22, 2021

@vpetersson I'd quite like to claim this one, after looking at the code base + tests in the outstanding PR the conversion should be relatively straight forward.

@robputt robputt self-assigned this Jul 14, 2021
@marvinmarnold marvinmarnold added enhancement New feature or request tech debt Testing, refactoring, etc and removed enhancement New feature or request labels Aug 5, 2021
@shawaj
Copy link
Member

shawaj commented Aug 16, 2021

Closed by #92

@shawaj shawaj closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Testing, refactoring, etc
Projects
None yet
Development

No branches or pull requests

5 participants